fix: Add description attribute to the from_proto method

Signed-off-by: gbmarc1 <marcantoine.belanger@shopify.com>
feast-dev · Jan 30, 2023 · 5cbfad0 · 5cbfad0
1 parent 75829f0
commit 5cbfad0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/sdk/python/feast/field.py b/sdk/python/feast/field.py
@@ -109,6 +109,7 @@ def from_proto(cls, field_proto: FieldProto):
             name=field_proto.name,
             dtype=from_value_type(value_type=value_type),
             tags=dict(field_proto.tags),
+            description=field_proto.description,
         )
 
     @classmethod

diff --git a/sdk/python/tests/unit/test_feature.py b/sdk/python/tests/unit/test_feature.py
@@ -27,3 +27,6 @@ def test_field_serialization_with_description():
 
     assert serialized_field.description == expected_description
     assert field_from_feature.description == expected_description
+
+    field = Field.from_proto(serialized_field)
+    assert field.description == expected_description