Remove logic duplicated by parent class

Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
feast-dev · Feb 2, 2022 · 5de401d · 5de401d
1 parent b90e125
commit 5de401d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 14 deletions.
diff --git a/sdk/python/feast/base_feature_view.py b/sdk/python/feast/base_feature_view.py
@@ -28,8 +28,8 @@
 class BaseFeatureView(ABC):
     """A FeatureView defines a logical grouping of features to be served."""
 
-    created_timestamp: Optional[datetime] = None
-    last_updated_timestamp: Optional[datetime] = None
+    created_timestamp: Optional[datetime]
+    last_updated_timestamp: Optional[datetime]
 
     @abstractmethod
     def __init__(self, name: str, features: List[Feature]):

diff --git a/sdk/python/feast/feature_view.py b/sdk/python/feast/feature_view.py
@@ -74,9 +74,7 @@ class FeatureView(BaseFeatureView):
     online: bool
     input: DataSource
     batch_source: DataSource
-    stream_source: Optional[DataSource] = None
-    created_timestamp: Optional[datetime] = None
-    last_updated_timestamp: Optional[datetime] = None
+    stream_source: Optional[DataSource]
     materialization_intervals: List[Tuple[datetime, datetime]]
 
     @log_exceptions
@@ -137,9 +135,6 @@ def __init__(
 
         self.materialization_intervals = []
 
-        self.created_timestamp: Optional[datetime] = None
-        self.last_updated_timestamp: Optional[datetime] = None
-
     # Note: Python requires redefining hash in child classes that override __eq__
     def __hash__(self):
         return super().__hash__()

diff --git a/sdk/python/feast/on_demand_feature_view.py b/sdk/python/feast/on_demand_feature_view.py
@@ -1,8 +1,7 @@
 import copy
 import functools
-from datetime import datetime
 from types import MethodType
-from typing import Dict, List, Optional, Type, Union
+from typing import Dict, List, Type, Union
 
 import dill
 import pandas as pd
@@ -48,8 +47,6 @@ class OnDemandFeatureView(BaseFeatureView):
     input_feature_view_projections: Dict[str, FeatureViewProjection]
     input_request_data_sources: Dict[str, RequestDataSource]
     udf: MethodType
-    created_timestamp: Optional[datetime] = None
-    last_updated_timestamp: Optional[datetime] = None
 
     @log_exceptions
     def __init__(
@@ -74,8 +71,6 @@ def __init__(
                 self.input_feature_view_projections[input_ref] = odfv_input.projection
 
         self.udf = udf
-        self.created_timestamp: Optional[datetime] = None
-        self.last_updated_timestamp: Optional[datetime] = None
 
     @property
     def proto_class(self) -> Type[OnDemandFeatureViewProto]: