Remove snowflake to feast type mapping for arrays (not supported)

feast-dev · Jan 8, 2024 · 7cc1cc0 · 7cc1cc0
1 parent e419e68
commit 7cc1cc0
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 2 deletions.
diff --git a/sdk/python/feast/type_map.py b/sdk/python/feast/type_map.py
@@ -651,7 +651,6 @@ def snowflake_type_to_feast_value_type(snowflake_type: str) -> ValueType:
         "TIMESTAMP_TZ": ValueType.UNIX_TIMESTAMP,
         "TIMESTAMP_LTZ": ValueType.UNIX_TIMESTAMP,
         "TIMESTAMP_NTZ": ValueType.UNIX_TIMESTAMP,
-        "ARRAY": ValueType.STRING,  # Actual list type cannot be inferred, so failing to a String instead
     }
     return type_map[snowflake_type]
 

diff --git a/sdk/python/tests/integration/materialization/test_snowflake.py b/sdk/python/tests/integration/materialization/test_snowflake.py
@@ -146,7 +146,6 @@ def test_snowflake_materialization_consistency_internal_with_lists(
         now = datetime.utcnow()
 
         full_feature_names = True
-        # TODO use both tz-naive & tz-aware timestamps to test that they're both correctly handled
         start_date = (now - timedelta(hours=5)).replace(tzinfo=utc)
         end_date = split_dt
         fs.materialize(