checking in progress...finding issues still

Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
feast-dev · Dec 16, 2024 · 7e979a9 · 7e979a9
1 parent 7b0d4fb
commit 7e979a9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 18 deletions.
diff --git a/sdk/python/feast/infra/online_stores/milvus_online_store/milvus.py b/sdk/python/feast/infra/online_stores/milvus_online_store/milvus.py
@@ -249,23 +249,10 @@ def update(
                 collection.drop()
                 self._collections.pop(collection_name, None)
 
-    def plan(
-        self, config: RepoConfig, desired_registry_proto: RegistryProto
-    ) -> List[InfraObject]:
-        project = config.project
-
-        infra_objects: List[InfraObject] = [
-            MilvusTable(
-                host=config.online_store.host,
-                port=config.online_store.port,
-                name=_table_id(project, FeatureView.from_proto(view)),
-            )
-            for view in [
-                *desired_registry_proto.feature_views,
-                *desired_registry_proto.stream_feature_views,
-            ]
-        ]
-        return infra_objects
+    # def plan(
+    #     self, config: RepoConfig, desired_registry_proto: RegistryProto
+    # ) -> List[InfraObject]:
+    #     raise NotImplementedError
 
     def teardown(
         self,

diff --git a/sdk/python/tests/conftest.py b/sdk/python/tests/conftest.py
@@ -210,6 +210,7 @@ def environment(request, worker_id):
 def vectordb_environment(request, worker_id):
     milvus_config = IntegrationTestRepoConfig(
         provider="local",
+        online_store="milvus",
         online_store_creator=MilvusOnlineStoreCreator,
         offline_store_creator=FileDataSourceCreator,
     )
@@ -228,7 +229,7 @@ def vectordb_environment(request, worker_id):
     else:
         yield e
 
-    # e.teardown()
+    e.teardown()
 
 
 _config_cache: Any = {}