Skip to content

Commit

Permalink
docs
Browse files Browse the repository at this point in the history
Signed-off-by: Tommy Hughes <tohughes@redhat.com>
  • Loading branch information
tchughesiv committed Dec 11, 2024
1 parent 8e95355 commit 98b2e70
Show file tree
Hide file tree
Showing 7 changed files with 18 additions and 115 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@
"cell_type": "markdown",
"metadata": {},
"source": [
"# Run a test client in Openshift\n",
"\n",
"Running the Feast Operator in OpenShift provides the added benefit of automated TLS via [service serving certificates](https://docs.openshift.com/container-platform/4.17/security/certificates/service-serving-certificate.html), which will be used in this client deployment."
"# Run a test client"
]
},
{
Expand All @@ -27,7 +25,7 @@
"cell_type": "markdown",
"metadata": {},
"source": [
"Then we create the client `Deployment` to apply the definitions, according to the [client-openshift.yaml](./client-openshift.yaml) manifest"
"Then we create the client `Deployment` to apply the definitions, according to the [client.yaml](./client.yaml) manifest"
]
},
{
Expand All @@ -44,7 +42,7 @@
"metadata": {},
"outputs": [],
"source": [
"!kubectl apply -f client-openshift.yaml"
"!kubectl apply -f client.yaml"
]
},
{
Expand Down
3 changes: 1 addition & 2 deletions examples/operator-quickstart/03-Uninstall.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,9 @@
"outputs": [],
"source": [
"!kubectl delete -f client.yaml\n",
"!kubectl delete -f client-openshift.yaml\n",
"!kubectl delete -f feast.yaml\n",
"!kubectl delete -f postgres.yaml\n",
"!make -C ../../infra/feast-operator undeploy"
"!kubectl delete -f ../../infra/feast-operator/dist/install.yaml"
]
},
{
Expand Down
3 changes: 1 addition & 2 deletions examples/operator-quickstart/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,5 @@
The following notebooks will guide you through an end-to-end journey to install and validate a simple Feast feature store in a
Kind Kubernetes or OpenShift cluster:
* [01-Install.ipynb](./01-Install.ipynb): Install and configure the cluster with the Operator.
* [02a-Client.ipynb](./02-Client.ipynb): In a kind/k8s cluster, validate the feature store with a remote test application.
* [02b-Client-OpenShift.ipynb](./02-Client-OpenShift.ipynb): In an OpenShift cluster, validate the feature store with a remote test application.
* [02-Client.ipynb](./02-Client.ipynb): In a kind/k8s cluster, validate the feature store with a remote test application.
* [03-Uninstall.ipynb](./03-Uninstall.ipynb): Clear the installed deployments.
103 changes: 0 additions & 103 deletions examples/operator-quickstart/client-openshift.yaml

This file was deleted.

11 changes: 9 additions & 2 deletions examples/operator-quickstart/client.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
---
kind: ServiceAccount
apiVersion: v1
metadata:
name: feast-example-client

---
apiVersion: apps/v1
kind: Deployment
metadata:
Expand All @@ -12,12 +19,13 @@ spec:
labels:
app: client
spec:
serviceAccountName: feast-example-client
initContainers:
- name: init-registry
command:
- sh
- '-c'
- 'until grpcurl -plaintext -d '''' -format text feast-example-registry.feast.svc.cluster.local:80 grpc.health.v1.Health/Check; do echo waiting for registry; sleep 2; done'
- 'until grpcurl -H "authorization: Bearer $(cat /var/run/secrets/kubernetes.io/serviceaccount/token)" -plaintext -d '''' -format text feast-example-registry.feast.svc.cluster.local:80 grpc.health.v1.Health/Check; do echo waiting for registry; sleep 2; done'
image: 'fullstorydev/grpcurl:v1.9.1-alpine'
- name: feast-apply
image: 'feastdev/feature-server:0.42.0'
Expand Down Expand Up @@ -67,7 +75,6 @@ spec:
containers:
- name: client
image: 'feastdev/feature-server:0.42.0'
imagePullPolicy: Always
workingDir: /feast-init/sample/feature_repo
command: ["sleep", "infinity"]
volumeMounts:
Expand Down
4 changes: 4 additions & 0 deletions examples/operator-quickstart/feast.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,8 @@ spec:
type: postgres
secretRef:
name: feast-postgresql
tls:
disable: true
registry:
local:
env:
Expand All @@ -95,3 +97,5 @@ spec:
type: sql
secretRef:
name: feast-postgresql
tls:
disable: true
1 change: 0 additions & 1 deletion examples/operator-quickstart/postgres.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ spec:
containers:
- name: postgres
image: 'postgres:16-alpine'
imagePullPolicy: IfNotPresent
ports:
- containerPort: 5432
envFrom:
Expand Down

0 comments on commit 98b2e70

Please sign in to comment.