Skip to content

Commit

Permalink
lint
Browse files Browse the repository at this point in the history
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
  • Loading branch information
jklegar committed Jan 18, 2021
1 parent 698ec10 commit dead34c
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
4 changes: 1 addition & 3 deletions sdk/python/feast/pyspark/launchers/aws/emr_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,7 @@ def _upload_jar(jar_s3_prefix: str, jar_path: str) -> str:
with open(jar_path, "rb") as f:
uri = urlparse(os.path.join(jar_s3_prefix, os.path.basename(jar_path)))
return urlunparse(
get_staging_client(uri.scheme).upload_fileobj(
f, jar_path, remote_uri=uri,
)
get_staging_client(uri.scheme).upload_fileobj(f, jar_path, remote_uri=uri)
)


Expand Down
6 changes: 5 additions & 1 deletion sdk/python/feast/pyspark/launchers/k8s/k8s.py
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,11 @@ def historical_feature_retrieval(
return cast(RetrievalJob, self._job_from_job_info(job_info))

def _upload_jar(self, jar_path: str) -> str:
if jar_path.startswith("s3://") or jar_path.startswith("s3a://") or jar_path.startswith("https://"):
if (
jar_path.startswith("s3://")
or jar_path.startswith("s3a://")
or jar_path.startswith("https://")
):
return jar_path
elif jar_path.startswith("file://"):
local_jar_path = urlparse(jar_path).path
Expand Down

0 comments on commit dead34c

Please sign in to comment.