Skip to content

Commit

Permalink
fixed lint oopsie & added to docstring on feature reference string co…
Browse files Browse the repository at this point in the history
…nvention

Signed-off-by: David Y Liu <davidyliuliu@gmail.com>
  • Loading branch information
mavysavydav committed Sep 30, 2021
1 parent 35411b3 commit e69ad89
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion sdk/python/feast/feature_service.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ class FeatureService:
Args:
name: Unique name of the feature service.
features: A list of Features that are grouped as part of this FeatureService.
The list may contain Feature Views, Feature Tables, or a subset of either.
The list may contain Feature Views, Feature Tables, or a subset of either. The
strings should be in the format 'my_feature_view:my_feature'.
tags (optional): A dictionary of key-value pairs used for organizing Feature
Services.
"""
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/feast/feature_view.py
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,7 @@ def get_projection(self, feature_view):
that's passed in as the argument. This allows users to make modifications to a FeatureView object
(e.g. the name) and then projecting those changes onto the corresponding actual FeatureView from the registry.
Currently all FeatureViews that are used must be registered and this method enables modifying those FeatureViews
while still making sure we're pulling the most up-to-date FeatureView from the registry to modify from.
while still making sure we're pulling the most up-to-date FeatureView from the registry to modify from.
Currently, only `FeatureView.features` is the field that's replaced the features from feature_view.
Expand Down

0 comments on commit e69ad89

Please sign in to comment.