Skip to content

Commit

Permalink
Apply docstring suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Willem Pienaar <6728866+woop@users.noreply.github.com>
Signed-off-by: Cody Lin <codyjlin@yahoomail.com>
  • Loading branch information
2 people authored and Cody Lin committed Jun 25, 2021
1 parent e87dad0 commit e6faf27
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions sdk/python/feast/infra/offline_stores/bigquery.py
Original file line number Diff line number Diff line change
Expand Up @@ -226,19 +226,19 @@ def to_df(self):

def to_sql(self) -> str:
"""
Returns the SQL query that can be modified and run by the user to create the BQ table.
Returns the SQL query that will be executed in BigQuery to build the historical feature table.
"""
return self.query

def to_bigquery(self, job_config: bigquery.QueryJobConfig = None) -> Optional[str]:
"""
Uploads the results of the BigQueryRetrievalJob directly to BigQuery.
Triggers the execution of a historical feature retrieval query and exports the results to a BigQuery table.
Args:
job_config: A bigquery.QueryJobConfig to specify options like destination table, dry run, etc.
job_config: An optional bigquery.QueryJobConfig to specify options like destination table, dry run, etc.
Returns:
Returns either the destination table name, none if job_config.dry_run, or raises an exception if job fails
Returns the destination table name or returns None if job_config.dry_run is True.
"""

@retry(wait=wait_fixed(10), stop=stop_after_delay(1800), reraise=True)
Expand Down

0 comments on commit e6faf27

Please sign in to comment.