Skip to content

Commit

Permalink
Add volume mount to prow jobs (#1034)
Browse files Browse the repository at this point in the history
Signed-off-by: Terence <terencelimxp@gmail.com>
  • Loading branch information
terryyylim authored Oct 8, 2020
1 parent d1807c9 commit eb865ea
Show file tree
Hide file tree
Showing 2 changed files with 33 additions and 8 deletions.
38 changes: 31 additions & 7 deletions .prow/config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,18 @@ presubmits:
requests:
cpu: "6"
memory: "6144Mi"
env:
- name: GOOGLE_APPLICATION_CREDENTIALS
value: /etc/gcloud/service-account.json
volumeMounts:
- mountPath: /etc/gcloud/service-account.json
name: service-account
readOnly: true
subPath: service-account.json
volumes:
- name: service-account
secret:
secretName: feast-service-account
skip_branches:
- ^v0\.(3|4)-branch$

Expand Down Expand Up @@ -186,14 +198,26 @@ presubmits:
always_run: true
spec:
containers:
- image: maven:3.6-jdk-11
command: ["infra/scripts/test-end-to-end-redis-cluster.sh"]
resources:
requests:
cpu: "6"
memory: "6144Mi"
- image: maven:3.6-jdk-11
command: ["infra/scripts/test-end-to-end-redis-cluster.sh"]
resources:
requests:
cpu: "6"
memory: "6144Mi"
env:
- name: GOOGLE_APPLICATION_CREDENTIALS
value: /etc/gcloud/service-account.json
volumeMounts:
- mountPath: /etc/gcloud/service-account.json
name: service-account
readOnly: true
subPath: service-account.json
volumes:
- name: service-account
secret:
secretName: feast-service-account
skip_branches:
- ^v0\.(3|4)-branch$
- ^v0\.(3|4)-branch$

- name: test-end-to-end-java-8
decorate: true
Expand Down
3 changes: 2 additions & 1 deletion infra/scripts/test-end-to-end-redis-cluster.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
set -e
set -o pipefail

test -z ${GOOGLE_APPLICATION_CREDENTIALS} && GOOGLE_APPLICATION_CREDENTIALS="/etc/service-account/service-account.json"
test -z ${GOOGLE_APPLICATION_CREDENTIALS} && GOOGLE_APPLICATION_CREDENTIALS="/etc/gcloud/service-account.json"
test -z ${SKIP_BUILD_JARS} && SKIP_BUILD_JARS="false"
test -z ${GOOGLE_CLOUD_PROJECT} && GOOGLE_CLOUD_PROJECT="kf-feast"
test -z ${TEMP_BUCKET} && TEMP_BUCKET="feast-templocation-kf-feast"
Expand All @@ -30,6 +30,7 @@ This script will run end-to-end tests for Feast Core and Online Serving.
source ${SCRIPTS_DIR}/setup-common-functions.sh

install_test_tools
install_gcloud_sdk
install_and_start_local_redis_cluster
install_and_start_local_postgres
install_and_start_local_zookeeper_and_kafka
Expand Down

0 comments on commit eb865ea

Please sign in to comment.