port over some tests from test_cli

Signed-off-by: Achal Shah <achals@gmail.com>

sdk/python/tests/integration/registration/test_cli.py

@@ -1,10 +1,12 @@
 import tempfile
 import uuid
+from contextlib import contextmanager
 from pathlib import Path, PosixPath
 from textwrap import dedent
 
 import pytest
 import yaml
+from assertpy import assertpy
 
 from feast import FeatureStore, RepoConfig
 from tests.integration.feature_repos.repo_configuration import FULL_REPO_CONFIGS
@@ -35,19 +37,49 @@ def test_universal_cli(test_repo_config) -> None:
         repo_example = repo_path / "example.py"
         repo_example.write_text(get_example_repo("example_feature_repo_1.py"))
         result = runner.run(["apply"], cwd=repo_path)
-        assert result.returncode == 0
+        assertpy.assert_that(result.returncode).is_equal_to(0)
+
+        # entity & feature view list commands should succeed
+        result = runner.run(["entities", "list"], cwd=repo_path)
+        assertpy.assert_that(result.returncode).is_equal_to(0)
+        result = runner.run(["feature-views", "list"], cwd=repo_path)
+        assertpy.assert_that(result.returncode).is_equal_to(0)
+        result = runner.run(["feature-services", "list"], cwd=repo_path)
+        assertpy.assert_that(result.returncode).is_equal_to(0)
+
+        # entity & feature view describe commands should succeed when objects exist
+        result = runner.run(["entities", "describe", "driver"], cwd=repo_path)
+        assertpy.assert_that(result.returncode).is_equal_to(0)
+        result = runner.run(
+            ["feature-views", "describe", "driver_locations"], cwd=repo_path
+        )
+        assertpy.assert_that(result.returncode).is_equal_to(0)
+        result = runner.run(
+            ["feature-services", "describe", "driver_locations_service"], cwd=repo_path
+        )
+        assertpy.assert_that(result.returncode).is_equal_to(0)
+
+        fs = FeatureStore(repo_path=str(repo_path))
+        assertpy.assert_that(fs.list_feature_views()).is_length(3)
+
+        # entity & feature view describe commands should fail when objects don't exist
+        result = runner.run(["entities", "describe", "foo"], cwd=repo_path)
+        assertpy.assert_that(result.returncode).is_equal_to(1)
+        result = runner.run(["feature-views", "describe", "foo"], cwd=repo_path)
+        assertpy.assert_that(result.returncode).is_equal_to(1)
+        result = runner.run(["feature-services", "describe", "foo"], cwd=repo_path)
+        assertpy.assert_that(result.returncode).is_equal_to(1)
 
         # Doing another apply should be a no op, and should not cause errors
         result = runner.run(["apply"], cwd=repo_path)
-        assert result.returncode == 0
-
+        assertpy.assert_that(result.returncode).is_equal_to(0)
         basic_rw_test(
             FeatureStore(repo_path=str(repo_path), config=None),
             view_name="driver_locations",
         )
 
         result = runner.run(["teardown"], cwd=repo_path)
-        assert result.returncode == 0
+        assertpy.assert_that(result.returncode).is_equal_to(0)
 
 
 def make_feature_store_yaml(project, test_repo_config, repo_dir_name: PosixPath):
@@ -73,3 +105,66 @@ def make_feature_store_yaml(project, test_repo_config, repo_dir_name: PosixPath)
     config_dict["repo_path"] = str(config_dict["repo_path"])
 
     return yaml.safe_dump(config_dict)
+
+
+@contextmanager
+def setup_third_party_provider_repo(provider_name: str):
+    with tempfile.TemporaryDirectory() as repo_dir_name:
+
+        # Construct an example repo in a temporary dir
+        repo_path = Path(repo_dir_name)
+
+        repo_config = repo_path / "feature_store.yaml"
+
+        repo_config.write_text(
+            dedent(
+                f"""
+        project: foo
+        registry: data/registry.db
+        provider: {provider_name}
+        online_store:
+            path: data/online_store.db
+            type: sqlite
+        offline_store:
+            type: file
+        """
+            )
+        )
+
+        (repo_path / "foo").mkdir()
+        repo_example = repo_path / "foo/provider.py"
+        repo_example.write_text(
+            (Path(__file__).parents[2] / "foo_provider.py").read_text()
+        )
+
+        yield repo_path
+
+
+def test_3rd_party_providers() -> None:
+    """
+    Test running apply on third party providers
+    """
+    runner = CliRunner()
+    # Check with incorrect built-in provider name (no dots)
+    with setup_third_party_provider_repo("feast123") as repo_path:
+        return_code, output = runner.run_with_output(["apply"], cwd=repo_path)
+        assertpy.assert_that(return_code).is_equal_to(1)
+        assertpy.assert_that(output).contains(b"Provider 'feast123' is not implemented")
+    # Check with incorrect third-party provider name (with dots)
+    with setup_third_party_provider_repo("feast_foo.Provider") as repo_path:
+        return_code, output = runner.run_with_output(["apply"], cwd=repo_path)
+        assertpy.assert_that(return_code).is_equal_to(1)
+        assertpy.assert_that(output).contains(
+            b"Could not import Provider module 'feast_foo'"
+        )
+    # Check with incorrect third-party provider name (with dots)
+    with setup_third_party_provider_repo("foo.FooProvider") as repo_path:
+        return_code, output = runner.run_with_output(["apply"], cwd=repo_path)
+        assertpy.assert_that(return_code).is_equal_to(1)
+        assertpy.assert_that(output).contains(
+            b"Could not import Provider 'FooProvider' from module 'foo'"
+        )
+    # Check with correct third-party provider name
+    with setup_third_party_provider_repo("foo.provider.FooProvider") as repo_path:
+        return_code, output = runner.run_with_output(["apply"], cwd=repo_path)
+        assertpy.assert_that(return_code).is_equal_to(0)