Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation for project name #1755

Closed
codyjlin opened this issue Aug 2, 2021 · 0 comments · Fixed by #1766
Closed

Add validation for project name #1755

codyjlin opened this issue Aug 2, 2021 · 0 comments · Fixed by #1766
Labels
good first issue Good for newcomers

Comments

@codyjlin
Copy link
Contributor

codyjlin commented Aug 2, 2021

Is your feature request related to a problem? Please describe.
A follow up to #1752 - I think project name should definitely be validated early on. Otherwise could run into an error message (#1752 (comment)) that is not obviously related to the project name.

Describe the solution you'd like
Validation upon feast apply that checks the project name. Can use the name validation function here.

Describe alternatives you've considered
There's probably more validation coverage to be done, and it could be done at a later time if there are higher priorities at the moment.

Additional context
@tedhtchang to take this simple addition on per #1752 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants