Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate project name upon feast.apply #1766

Merged

Conversation

tedhtchang
Copy link
Contributor

Signed-off-by: ted chang htchang@us.ibm.com

What this PR does / why we need it:
Check invalid project name
Which issue(s) this PR fixes:
Fixes #1755

Does this PR introduce a user-facing change?:

User will get an error upon running feast.apply with invalid project name.

@feast-ci-bot
Copy link
Collaborator

Hi @tedhtchang. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tedhtchang
Copy link
Contributor Author

/cc @tsotnet

@feast-ci-bot feast-ci-bot removed the request for review from a team August 7, 2021 00:50
@tedhtchang tedhtchang force-pushed the validate_project_name_at_apply branch from 6828b5e to 8d6eaf6 Compare August 7, 2021 16:12
@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2021

Codecov Report

Merging #1766 (662244a) into master (54bbe5f) will decrease coverage by 20.38%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1766       +/-   ##
===========================================
- Coverage   84.69%   64.30%   -20.39%     
===========================================
  Files          85       82        -3     
  Lines        6297     6233       -64     
===========================================
- Hits         5333     4008     -1325     
- Misses        964     2225     +1261     
Flag Coverage Δ
integrationtests ?
unittests 64.30% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/repo_config.py 90.62% <100.00%> (-2.00%) ⬇️
.../tests/integration/scaffolding/test_repo_config.py 100.00% <100.00%> (ø)
.../integration/online_store/test_online_retrieval.py 17.39% <0.00%> (-82.61%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 18.18% <0.00%> (-81.82%) ⬇️
...gration/registration/test_feature_service_apply.py 31.25% <0.00%> (-68.75%) ⬇️
...hon/tests/integration/registration/test_cli_gcp.py 31.70% <0.00%> (-68.30%) ⬇️
...n/tests/integration/registration/test_cli_redis.py 32.55% <0.00%> (-67.45%) ⬇️
sdk/python/feast/infra/online_stores/redis.py 30.35% <0.00%> (-64.29%) ⬇️
sdk/python/feast/infra/online_stores/dynamodb.py 30.37% <0.00%> (-60.76%) ⬇️
sdk/python/feast/infra/online_stores/datastore.py 31.03% <0.00%> (-59.49%) ⬇️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54bbe5f...662244a. Read the comment docs.

Signed-off-by: ted chang <htchang@us.ibm.com>
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tedhtchang, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Member

woop commented Aug 17, 2021

/lgtm

@feast-ci-bot feast-ci-bot merged commit c0fe653 into feast-dev:master Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add validation for project name
5 participants