-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate project name upon feast.apply #1766
Validate project name upon feast.apply #1766
Conversation
Hi @tedhtchang. Thanks for your PR. I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @tsotnet |
6828b5e
to
8d6eaf6
Compare
Codecov Report
@@ Coverage Diff @@
## master #1766 +/- ##
===========================================
- Coverage 84.69% 64.30% -20.39%
===========================================
Files 85 82 -3
Lines 6297 6233 -64
===========================================
- Hits 5333 4008 -1325
- Misses 964 2225 +1261
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: ted chang <htchang@us.ibm.com>
8d6eaf6
to
662244a
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tedhtchang, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Signed-off-by: ted chang htchang@us.ibm.com
What this PR does / why we need it:
Check invalid project name
Which issue(s) this PR fixes:
Fixes #1755
Does this PR introduce a user-facing change?: