Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate list of storages in specs service #66

Closed
zhilingc opened this issue Jan 14, 2019 · 0 comments
Closed

Deduplicate list of storages in specs service #66

zhilingc opened this issue Jan 14, 2019 · 0 comments

Comments

@zhilingc
Copy link
Collaborator

Expected Behavior

Ingestion should retrieve a set of storages from core, not a list with multiples.

Current Behavior

Given an import job with features sharing stores, the ingestion job will query for the full list of storage ids with duplicates. This will fail the job since the output list of storage specs will be smaller than the list of ids.

Possible Solution

Deduplicating the list of required storage specs will fix this problem (in Specs.java)
@zhilingc zhilingc assigned zhilingc and tims and unassigned zhilingc Jan 14, 2019
@pradithya pradithya mentioned this issue Jan 14, 2019
Merged
@tims tims mentioned this issue Jan 14, 2019
Merged
@woop woop unassigned tims May 16, 2020
lokeshrangineni pushed a commit to lokeshrangineni/feast that referenced this issue Aug 7, 2024
@redhatHameed
Merge pull request feast-dev#66 from lokeshrangineni/feature/fix-inte…
3f38ffb 
…gration-test

Updating the offline integration test permissions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tims @zhilingc