Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feast cli feature-sets describe broken #727

Closed
zhilingc opened this issue May 22, 2020 · 0 comments · Fixed by #731
Closed

feast cli feature-sets describe broken #727

zhilingc opened this issue May 22, 2020 · 0 comments · Fixed by #731
Assignees
Labels

Comments

@zhilingc
Copy link
Collaborator

Expected Behavior

feast feature-sets describe <name> cannot be used because it doesn't allow the user to set a project, nor does it default to any value.

Steps to reproduce

Call feast feature-sets describe <some_feature_set>

Specifications

  • Version: 0.5.0

Possible Solution

The method calls fs = feast_client.get_feature_set(name=name). Since no project is provided to get_feature_set, a default project needs to be set in the client.

Either

  1. Allow users to pass feature set ids with projects specified (project/feature_set) or
  2. Allow users to set a default project.

The method should fall back to a default project (default) should one not be provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants