Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix project argument for feature set describe in CLI #731

Merged
merged 1 commit into from
May 30, 2020

Conversation

terryyylim
Copy link
Member

@terryyylim terryyylim commented May 22, 2020

What this PR does / why we need it:
feast feature-sets describe <name> cannot be used because it doesn't allow the user to set a project, nor does it default to any value.

Which issue(s) this PR fixes:

Fixes #727

Does this PR introduce a user-facing change?:

Users can now pass in --project parameter to retrieve information about a feature set using cli.

@terryyylim
Copy link
Member Author

/test test-end-to-end-batch

sdk/python/feast/cli.py Outdated Show resolved Hide resolved
sdk/python/feast/cli.py Outdated Show resolved Hide resolved
@woop
Copy link
Member

woop commented May 23, 2020

Oh nice, thanks for this @terryyylim!

I think Fix project argument for feature set describe in CLI would be a better title. The titles are used for our change log so we want them to be human readable.

Also, you need to add a kind label to all PRs. This one requires kind/bug.

@terryyylim terryyylim changed the title Fix feature_set_describe cli Fix project argument for feature set describe in CLI May 23, 2020
@terryyylim terryyylim force-pushed the fix-describe-fs-cli branch from 642d4f9 to 77d94fb Compare May 26, 2020 02:03
@terryyylim terryyylim requested a review from pyalex as a code owner May 26, 2020 02:03
@terryyylim
Copy link
Member Author

/test test-end-to-end-redis-cluster

@woop
Copy link
Member

woop commented May 26, 2020

@terryyylim Remember to update the release note. Other than that it looks good.

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terryyylim, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Member

woop commented May 30, 2020

/lgtm

@feast-ci-bot feast-ci-bot merged commit 0ec49cd into feast-dev:master May 30, 2020
khorshuheng pushed a commit to khorshuheng/feast that referenced this pull request Jun 5, 2020
Co-authored-by: Terence <terence.limxp@go-jek.com>
khorshuheng pushed a commit that referenced this pull request Jun 5, 2020
Co-authored-by: Terence <terence.limxp@go-jek.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feast cli feature-sets describe broken
3 participants