-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix project argument for feature set describe in CLI #731
Conversation
409ae39
to
642d4f9
Compare
/test test-end-to-end-batch |
Oh nice, thanks for this @terryyylim! I think Also, you need to add a |
642d4f9
to
77d94fb
Compare
/test test-end-to-end-redis-cluster |
@terryyylim Remember to update the release note. Other than that it looks good. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terryyylim, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Co-authored-by: Terence <terence.limxp@go-jek.com>
Co-authored-by: Terence <terence.limxp@go-jek.com>
What this PR does / why we need it:
feast feature-sets describe <name>
cannot be used because it doesn't allow the user to set a project, nor does it default to any value.Which issue(s) this PR fixes:
Fixes #727
Does this PR introduce a user-facing change?: