Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add redis SSL support to the offline-to-online ingestion job #1025

Merged
merged 1 commit into from
Oct 7, 2020

Conversation

oavdeev
Copy link
Collaborator

@oavdeev oavdeev commented Oct 6, 2020

What this PR does / why we need it:
Support SSL option for redis connections (aka "encryption in-transit" in AWS ElastiCache) in the Spark job. SSL is already supported by lettuce/springboot out of the box, so this brings Spark to feature parity.

Does this PR introduce a user-facing change?:

NONE

@feast-ci-bot
Copy link
Collaborator

Hi @oavdeev. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@oavdeev
Copy link
Collaborator Author

oavdeev commented Oct 6, 2020

/assign @woop

@oavdeev
Copy link
Collaborator Author

oavdeev commented Oct 6, 2020

/assign @pyalex

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oavdeev, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Oleg Avdeev <oleg.v.avdeev@gmail.com>
@pyalex
Copy link
Collaborator

pyalex commented Oct 7, 2020

/lgtm

@oavdeev
Copy link
Collaborator Author

oavdeev commented Oct 7, 2020

/kind feature

@feast-ci-bot feast-ci-bot added kind/feature New feature or request and removed needs-kind labels Oct 7, 2020
@woop
Copy link
Member

woop commented Oct 7, 2020

/ok-to-test

@feast-ci-bot feast-ci-bot merged commit 61133e4 into feast-dev:master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants