Feast SDK integration for historical feature retrieval using Spark #1054
Conversation
khorshuheng
requested review from
davidheryanto,
pyalex,
woop and
zhilingc
as code owners
| } | ||
|
|
||
|
|
||
| def start_historical_feature_retrieval_spark_session( |
There was a problem hiding this comment.
I'm not 100% follow what is this for? I'd expect this to be within the local launcher as it assumes that you have Spark env setup.
There was a problem hiding this comment.
This function is useful for cases where, the user has their own SparkSession, in a jupyter notebook for example. In such case, it might be more convenient to return a Spark dataframe, rather than the actual output.
khorshuheng
force-pushed
the
sdk-historical-retrieval
branch
from
245f49a
to
2ba5ab9
Compare
Signed-off-by: Khor Shu Heng <khor.heng@gojek.com>
khorshuheng
force-pushed
the
sdk-historical-retrieval
branch
3 times, most recently
from
8df72d2
to
9c4f1cc
Compare
Signed-off-by: Khor Shu Heng <khor.heng@gojek.com>
khorshuheng
force-pushed
the
sdk-historical-retrieval
branch
from
9c4f1cc
to
a739121
Compare
Signed-off-by: Khor Shu Heng <khor.heng@gojek.com>
khorshuheng
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: khorshuheng, pyalex The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
What this PR does / why we need it:
Add historical feature retrieval job back to the Feast client again.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: