Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup CLI and Python dependencies #1062

Merged
merged 2 commits into from
Oct 20, 2020

Conversation

terryyylim
Copy link
Member

What this PR does / why we need it:

  • Puts emr-related cli commands under jobs group, where we'll be adding future support for dataproc as well.
  • Removes kafka dependencies.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

sync_offline_to_online, start_stream_to_online, stop_stream_to_online and list_jobs commands in cli will now be found under `jobs` group

@terryyylim
Copy link
Member Author

/retest

Signed-off-by: Terence <terencelimxp@gmail.com>
Signed-off-by: Terence <terencelimxp@gmail.com>
@terryyylim
Copy link
Member Author

/retest

@woop woop changed the title Cleanup cli and python dependencies Cleanup CLI and Python dependencies Oct 20, 2020
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terryyylim, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Member

woop commented Oct 20, 2020

/lgtm

@feast-ci-bot feast-ci-bot merged commit 5db62d3 into feast-dev:master Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants