Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more validation in feature spec registration #11

Merged
merged 1 commit into from
Dec 24, 2018

Conversation

pradithya
Copy link
Collaborator

Add validation in feature spec registration to prevent users from registering feature that uses unsupported storage.

Copy link
Member

@woop woop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@zhilingc zhilingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm~

@zhilingc zhilingc merged commit 3b17d7a into master Dec 24, 2018
@zhilingc zhilingc deleted the feature_spec_validation branch December 24, 2018 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants