Add validation when feature type is changed #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyalex
reviewed
Oct 28, 2020
serving/src/main/java/feast/serving/service/OnlineServingServiceV2.java
Outdated
Show resolved
Hide resolved
pyalex
reviewed
Oct 28, 2020
| allValueMaps.putAll(valueMap); | ||
|
|
||
| boolean isNotFound = false; |
There was a problem hiding this comment.
isn't it the same as
isNotFound = !isSameType
pyalex
reviewed
Oct 28, 2020
| HashMap<String, String> typingMap = | ||
| new HashMap<>() { | ||
| { | ||
| put("BYTES", "BYTES_VAL"); |
There was a problem hiding this comment.
why convert to string? Can we use original enum values instead?
pyalex
reviewed
Oct 28, 2020
| @@ -196,11 +241,11 @@ public GetOnlineFeaturesResponse getOnlineFeatures(GetOnlineFeaturesRequestV2 re | |||
| } | |||
|
|
|||
| private static Map<String, ValueProto.Value> unpackValueMap( | |||
| Optional<Feature> feature, boolean isOutsideMaxAge) { | |||
| Optional<Feature> feature, boolean isOutsideMaxAge, boolean isSameType) { | |||
There was a problem hiding this comment.
sameType name seems not very clear here
Signed-off-by: Terence <terencelimxp@gmail.com>
Signed-off-by: Terence <terencelimxp@gmail.com>
terryyylim
force-pushed
the
serving-type-check
branch
from
5e9adc1 to
1f407e3
Compare
Signed-off-by: Terence <terencelimxp@gmail.com>
Signed-off-by: Terence <terencelimxp@gmail.com>
|
/test test-end-to-end-gcp |
pyalex
approved these changes
Oct 28, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pyalex, terryyylim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Terence terencelimxp@gmail.com
What this PR does / why we need it:
In the past, we didn't allow changes to feature types so this validation was not necessary. As we think about implementing deletion of feature tables, we'll need to consider how old values stored in redis will be retrieved. This PR is the first step to handling older values that are based of older types.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: