Ensure consistency of github workflow #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terryyylim
requested review from
davidheryanto,
khorshuheng,
pyalex,
woop and
zhilingc
as code owners
terryyylim
force-pushed
the
ensure-workflow-consistency
branch
from
7347592
to
9126989
Compare
terryyylim
force-pushed
the
ensure-workflow-consistency
branch
2 times, most recently
from
d905e8c
to
5fdaf36
Compare
|
/retest |
1 similar comment
|
/retest |
terryyylim
force-pushed
the
ensure-workflow-consistency
branch
3 times, most recently
from
f92c4f2
to
396f58a
Compare
terryyylim
changed the title
terryyylim
force-pushed
the
ensure-workflow-consistency
branch
from
396f58a
to
4202eea
Compare
terryyylim
changed the title
|
/retest |
Signed-off-by: Terence <terencelimxp@gmail.com>
Signed-off-by: Terence <terencelimxp@gmail.com>
Signed-off-by: Terence <terencelimxp@gmail.com>
Signed-off-by: Terence <terencelimxp@gmail.com>
Signed-off-by: Terence <terencelimxp@gmail.com>
Signed-off-by: Terence <terencelimxp@gmail.com>
Signed-off-by: Terence <terencelimxp@gmail.com>
terryyylim
force-pushed
the
ensure-workflow-consistency
branch
from
4202eea
to
8232cdb
Compare
Signed-off-by: Terence <terencelimxp@gmail.com>
woop
approved these changes
Nov 19, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terryyylim, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
pyalex
pushed a commit
that referenced
this pull request
Nov 24, 2020
* Ensure consistency of github workflow Signed-off-by: Terence <terencelimxp@gmail.com> * Shift GCR latest tag workflow to release Signed-off-by: Terence <terencelimxp@gmail.com> * Fix production build arg Signed-off-by: Terence <terencelimxp@gmail.com> * Fix docker-compose test Signed-off-by: Terence <terencelimxp@gmail.com> * Use single step for dockerhub build and push Signed-off-by: Terence <terencelimxp@gmail.com> * Revert docker compose fix Signed-off-by: Terence <terencelimxp@gmail.com> * Simplify to single build push stage Signed-off-by: Terence <terencelimxp@gmail.com> * Remove build and just tag Signed-off-by: Terence <terencelimxp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Terence terencelimxp@gmail.com
What this PR does / why we need it:
This PR ensures the following consistency:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: