Fix github workflow deprecating env variable #1158
Conversation
Signed-off-by: Terence <terencelimxp@gmail.com>
terryyylim
requested review from
davidheryanto,
khorshuheng,
pyalex,
woop and
zhilingc
as code owners
| @@ -28,7 +28,7 @@ jobs: | |||
| --archive-uri ${MAVEN_CACHE} \ | |||
| --output-dir . | |||
| - name: Get version | |||
| run: echo ::set-env name=RELEASE_VERSION::${GITHUB_REF#refs/*/} | |||
| run: echo "RELEASE_VERSION=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV | |||
There was a problem hiding this comment.
Not really sure what this command now does...
There was a problem hiding this comment.
Recommended upgrade from github workflow docs.
|
/retest |
|
@terryyylim: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pyalex, terryyylim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Terence <terencelimxp@gmail.com>
Signed-off-by: Terence terencelimxp@gmail.com
What this PR does / why we need it:
Github actions will be deprecating
set-envas described in this blog post. Thus, we need to update it before it causes issues to our ci/cd.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: