Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize flaky e2e tests #1173

Merged
merged 9 commits into from
Nov 17, 2020
Merged

Stabilize flaky e2e tests #1173

merged 9 commits into from
Nov 17, 2020

Conversation

pyalex
Copy link
Collaborator

@pyalex pyalex commented Nov 17, 2020

Signed-off-by: Oleksii Moskalenko moskalenko.alexey@gmail.com

What this PR does / why we need it:

This PR addresses

  1. Issue with pytest parametrized fixtures dependencies: currently resolving doesn't work, thus I turned off auth parametrization
  2. mvn cache issue in e2e tests
  3. ingestion jar building fails. It was moved from "self-hosted" runner and now jar is being shared via flow artifactis

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:


Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>

pipeline fails

Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>

pipeline fails

Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>

pipeline fails

Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khorshuheng, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@khorshuheng
Copy link
Collaborator

/lgtm

@feast-ci-bot feast-ci-bot merged commit 5962756 into feast-dev:master Nov 17, 2020
pyalex added a commit that referenced this pull request Nov 24, 2020
* use mvn cache in e2e & skip auth

Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>

* correct path & pytest param

Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>

* use artifacts to store ingestion jar

Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>

* add mvn cache

Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>

* download artifact to path

Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>

* mvn cache

Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>

pipeline fails

Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>

pipeline fails

Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>

pipeline fails

Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>

* check failing

Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>

* cache for master build of ingestion jar

Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>

* drop auth=true completely

Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants