Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing GRPC interceptor in serving & go sdk #1212

Merged
merged 3 commits into from
Dec 4, 2020

Conversation

pyalex
Copy link
Collaborator

@pyalex pyalex commented Dec 3, 2020

What this PR does / why we need it:

Adding grpc interceptors to serving and go client instead of manual tracing. That would allow cross-service tracing.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

`NewTraceableGrpcClient` constructor was added to go sdk. It allows to pass Tracer on client creation phase

Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
@pyalex pyalex changed the title Tracing interceptor Tracing GRPC interceptor in serving & go sdk Dec 3, 2020
@pyalex pyalex added the kind/feature New feature or request label Dec 3, 2020
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
@feast-ci-bot
Copy link
Collaborator

@pyalex: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
test-end-to-end-gcp 4d48bc5 link /test test-end-to-end-gcp
python-sdk-integration-test 4d48bc5 link /test python-sdk-integration-test
test-end-to-end-aws 4d48bc5 link /test test-end-to-end-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pyalex pyalex assigned pyalex and khorshuheng and unassigned pyalex Dec 3, 2020
@woop
Copy link
Member

woop commented Dec 3, 2020

@pyalex is the plan to only implement this functionality in Golang, and not Java?

@pyalex
Copy link
Collaborator Author

pyalex commented Dec 3, 2020

@woop the plan was to introduce minimal changes. do you think java sdk needs to have this functionality as well?

@woop
Copy link
Member

woop commented Dec 3, 2020

@woop the plan was to introduce minimal changes. do you think java sdk needs to have this functionality as well?

It's fine to have it only for Go, but perhaps we shouldnt document this in feast.dev but only in the API docs.

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khorshuheng, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@khorshuheng
Copy link
Collaborator

/lgtm

@khorshuheng khorshuheng merged commit 30504f4 into feast-dev:v0.7-branch Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants