Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance job api to return associated feature table and start time #1259

Merged
merged 8 commits into from
Jan 12, 2021

Conversation

khorshuheng
Copy link
Collaborator

@khorshuheng khorshuheng commented Jan 8, 2021

Signed-off-by: Khor Shu Heng khor.heng@gojek.com

What this PR does / why we need it:
As part of an effort to create an UI for Feast, the JobService API needs to return more information, in particular, job start time and the feature table associated with the ingestion jobs.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

gRPC responses for submitting spark jobs via job service now have additional fields: start time for all types of jobs, and feature table for ingestion jobs. These fields have also been added to the corresponding Job object returned by list_jobs and get_job API.

Signed-off-by: Khor Shu Heng <khor.heng@gojek.com>
Signed-off-by: Khor Shu Heng <khor.heng@gojek.com>
Signed-off-by: Khor Shu Heng <khor.heng@gojek.com>
Signed-off-by: Khor Shu Heng <khor.heng@gojek.com>
Signed-off-by: Khor Shu Heng <khor.heng@gojek.com>
Signed-off-by: Khor Shu Heng <khor.heng@gojek.com>
Signed-off-by: Khor Shu Heng <khor.heng@gojek.com>
@pyalex
Copy link
Collaborator

pyalex commented Jan 11, 2021

/test test-end-to-end-aws

Signed-off-by: Khor Shu Heng <khor.heng@gojek.com>
@khorshuheng
Copy link
Collaborator Author

/test test-end-to-end-gcp

@feast-ci-bot
Copy link
Collaborator

feast-ci-bot commented Jan 11, 2021

@khorshuheng: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
test-end-to-end-azure c5b4e98 link /test test-end-to-end-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khorshuheng, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pyalex
Copy link
Collaborator

pyalex commented Jan 12, 2021

/lgtm

@pyalex pyalex merged commit f4f345e into feast-dev:master Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants