Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make nodes priority (for redis cluster) configurable in Serving #1260

Merged
merged 1 commit into from
Jan 11, 2021

Conversation

pyalex
Copy link
Collaborator

@pyalex pyalex commented Jan 8, 2021

Signed-off-by: Oleksii Moskalenko moskalenko.alexey@gmail.com

What this PR does / why we need it:

Prior to this PR Feast Serving only read from master nodes in redis cluster. Here I make it configurable via application.yaml.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

new configuration option

RedisClusterConfig:
   read_from: MASTER | MASTER_PREFERRED | REPLICA | REPLICA_PREFERRED

Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
@feast-ci-bot
Copy link
Collaborator

feast-ci-bot commented Jan 8, 2021

@pyalex: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
test-end-to-end-azure 29c3c33 link /test test-end-to-end-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pyalex
Copy link
Collaborator Author

pyalex commented Jan 8, 2021

/test test-end-to-end-aws

Copy link
Collaborator

@khorshuheng khorshuheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khorshuheng, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pyalex pyalex merged commit 286941d into feast-dev:master Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants