Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix historical test flakiness #1270

Merged
merged 1 commit into from
Jan 16, 2021
Merged

Conversation

jklegar
Copy link
Collaborator

@jklegar jklegar commented Jan 15, 2021

Signed-off-by: Jacob Klegar jacob@tecton.ai

What this PR does / why we need it: small bugfix to fix flaky historical test

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Jacob Klegar <jacob@tecton.ai>
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jklegar, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Member

woop commented Jan 15, 2021

/lgtm

@feast-ci-bot
Copy link
Collaborator

@jklegar: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
test-end-to-end-aws 3a7e871 link /test test-end-to-end-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jklegar jklegar merged commit 13f6ccb into feast-dev:master Jan 16, 2021
@jklegar jklegar deleted the jacob_fix_histtest branch February 4, 2021 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants