Add feature table name filter to jobs list api #1282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terryyylim
requested review from
davidheryanto,
khorshuheng,
pyalex,
woop and
zhilingc
as code owners
terryyylim
force-pushed
the
enhance-job-list-filter
branch
3 times, most recently
from
80e357c
to
c219741
Compare
|
/retest |
4 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
terryyylim
force-pushed
the
enhance-job-list-filter
branch
2 times, most recently
from
4be288d
to
ef6a4be
Compare
Signed-off-by: Terence <terencelimxp@gmail.com>
Signed-off-by: Terence <terencelimxp@gmail.com>
Signed-off-by: Terence <terencelimxp@gmail.com>
Signed-off-by: Terence <terencelimxp@gmail.com>
Signed-off-by: Terence <terencelimxp@gmail.com>
terryyylim
force-pushed
the
enhance-job-list-filter
branch
from
ef6a4be
to
0624a1b
Compare
|
/retest |
terryyylim
force-pushed
the
enhance-job-list-filter
branch
from
0624a1b
to
6c5666f
Compare
Signed-off-by: Terence <terencelimxp@gmail.com>
terryyylim
force-pushed
the
enhance-job-list-filter
branch
2 times, most recently
from
2b94b6d
to
bae5445
Compare
terryyylim
force-pushed
the
enhance-job-list-filter
branch
from
bae5445
to
a66da58
Compare
Signed-off-by: Terence <terencelimxp@gmail.com>
terryyylim
force-pushed
the
enhance-job-list-filter
branch
from
a66da58
to
b704dba
Compare
Signed-off-by: Terence <terencelimxp@gmail.com>
terryyylim
force-pushed
the
enhance-job-list-filter
branch
from
ac4c8ee
to
1dc4ef6
Compare
Signed-off-by: Terence <terencelimxp@gmail.com>
|
/retest |
1 similar comment
|
/retest |
pyalex
approved these changes
Jan 28, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pyalex, terryyylim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
@terryyylim: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Terence terencelimxp@gmail.com
What this PR does / why we need it:
This PR adds feature table name filter to
ListJobsapi. This would allow us to perform filtering on server side.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: