Enable user to provide spark job template as input for jobservice deployment #1285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khorshuheng
requested review from
davidheryanto,
pyalex,
woop and
zhilingc
as code owners
khorshuheng
changed the title
…loyment Signed-off-by: Khor Shu Heng <khor.heng@gojek.com>
khorshuheng
force-pushed
the
spark-job-template-option
branch
from
b386697 to
763639b
Compare
khorshuheng
changed the title
Signed-off-by: Khor Shu Heng <khor.heng@gojek.com>
khorshuheng
force-pushed
the
spark-job-template-option
branch
from
43093b6 to
19d347c
Compare
oavdeev
approved these changes
Jan 26, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: khorshuheng, oavdeev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Khor Shu Heng khor.heng@gojek.com
What this PR does / why we need it:
Currently, there's no way for users to mount the spark job template on the jobservice pod. This PR enables the user to mount custom job template as configmap.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: