Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read and write path for Datastore and SQLite #1376

Merged
merged 6 commits into from
Mar 12, 2021

Conversation

oavdeev
Copy link
Collaborator

@oavdeev oavdeev commented Mar 9, 2021

What this PR does / why we need it:
Implement read and write path for online store, both for local (SQLite) mode and GCP (Datastore).

It only implements a lower-level interface for reading and writing to be used internally in Feast, I expect we'll later have nicer wrappers over those methods in the SDK.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@oavdeev oavdeev force-pushed the firebase-rw branch 2 times, most recently from 1860430 to 6bc92b9 Compare March 10, 2021 16:51
Signed-off-by: Oleg Avdeev <oleg.v.avdeev@gmail.com>
@oavdeev oavdeev changed the title [WIP] Firebase read write Datastore read write Mar 10, 2021
@oavdeev oavdeev changed the title Datastore read write Read and write path for Datastore and SQLite Mar 10, 2021
@oavdeev
Copy link
Collaborator Author

oavdeev commented Mar 10, 2021

/kind feature

@feast-ci-bot feast-ci-bot added kind/feature New feature or request and removed needs-kind labels Mar 10, 2021
oavdeev added 3 commits March 10, 2021 16:34
Signed-off-by: Oleg Avdeev <oleg.v.avdeev@gmail.com>
Signed-off-by: Oleg Avdeev <oleg.v.avdeev@gmail.com>
Signed-off-by: Oleg Avdeev <oleg.v.avdeev@gmail.com>
Signed-off-by: Oleg Avdeev <oleg.v.avdeev@gmail.com>
@oavdeev oavdeev force-pushed the firebase-rw branch 2 times, most recently from 4674ec7 to 18a093f Compare March 11, 2021 23:52
Signed-off-by: Oleg Avdeev <oleg.v.avdeev@gmail.com>
@oavdeev
Copy link
Collaborator Author

oavdeev commented Mar 12, 2021

/retest

@woop
Copy link
Member

woop commented Mar 12, 2021

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oavdeev, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 09f4208 into feast-dev:master Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants