Added RFC for Feast Python SDK #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhilingc
requested changes
Dec 24, 2018
There was a problem hiding this comment.
Can we change the sample workflow to follow more closely to what @pradithya and I have done? other than that, looks great
Absolutely. |
pradithya
reviewed
Dec 27, 2018
rfcs/0000-python-sdk.md
Outdated
| The feature set is simply an object that locally tracks which entity, granularity, and features you are interested in. | ||
|
|
||
| ```python | ||
| feature_set = fs.create_feature_set(entity='driver', granularity='minute', features=['latitude', 'longitude', 'event_time']) |
There was a problem hiding this comment.
Do you think it make more sense to have FeatureSet creation outside of client, and then to get training/serving data we pass the instance into the corresponding client method?
# create feature set
feature_set = FeatureSet(entity='driver', granularity='minute', features=['latitude', 'longitude', 'event_time'])
# training dataset
dataset_info = fs.create_training_dataset(feature_set, start_date='2018-01-01', end_date='2018-02-01')
dataset_info.download(dest=file_path, type='feather')
df = dataset_info.download_to_df()
# serving
feature_data = fs.get_serving_data(feature_set, keys, type='last')
pradithya
reviewed
Dec 27, 2018
|
I've incorporated your feedback @pradithya, @zhilingc. I have also written out a reference level explanation of the important classes and methods. Can you please have a look? |
zhilingc
approved these changes
Jan 1, 2019
pradithya
approved these changes
Jan 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds an RFC for a Python SDK