Port telemetry to FeatureStore API #1446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/kind housekeeping |
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
jklegar
force-pushed
the
jacob_port_telemetry
branch
from
9a334e1 to
3ccb328
Compare
|
@jklegar would it make sense to add telemetry to all of our methods on the FeatureStore class? |
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
Signed-off-by: Willem Pienaar <git@willem.co>
jklegar
commented
Apr 9, 2021
sdk/python/feast/telemetry.py
Outdated
| try: | ||
| sdk_version = pkg_resources.get_distribution("feast").version | ||
| except pkg_resources.DistributionNotFound: | ||
| sdk_version = "local build" |
There was a problem hiding this comment.
I think this was accidentally left in fyi
Signed-off-by: Willem Pienaar <git@willem.co>
Signed-off-by: Willem Pienaar <git@willem.co>
Signed-off-by: Willem Pienaar <git@willem.co>
|
/lgtm |
woop
approved these changes
Apr 10, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jklegar, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jacob Klegar jacob@tecton.ai
What this PR does / why we need it: Ports opt-out telemetry to the new FeatureStore API
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: