Fix time zone access with native python datetimes #1469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai>
tsotnet
force-pushed
the
fix-native-datetime-tz
branch
from
9289758 to
10e40f7
Compare
jklegar
approved these changes
Apr 14, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jklegar, tsotnet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Looks like x.tz exists only for pandas Timestamp type (which extends Python's native datetime object), but it that fields doesn't exist in the original datetime object. Given that tz is just an alias for tzinfo, x.tzinfo exists both in pandas Timestamp & in Python's native datetime objects, so I'm changing it to that.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: