Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python docs formatting fixes #1473

Merged
merged 2 commits into from
Apr 22, 2021
Merged

Conversation

jklegar
Copy link
Collaborator

@jklegar jklegar commented Apr 16, 2021

Signed-off-by: Jacob Klegar jacob@tecton.ai

What this PR does / why we need it: Updates and fixes formatting issues in the python SDK reference documentation

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jklegar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jklegar
Copy link
Collaborator Author

jklegar commented Apr 16, 2021

/kind housekeeping

Copy link
Member

@woop woop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build still failing btw

@jklegar
Copy link
Collaborator Author

jklegar commented Apr 19, 2021

/test test-telemetry

Signed-off-by: Jacob Klegar <jacob@tecton.ai>
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
@woop
Copy link
Member

woop commented Apr 22, 2021

/lgtm

@jklegar jklegar merged commit 36c77dd into feast-dev:master Apr 22, 2021
woop pushed a commit that referenced this pull request Apr 27, 2021
* Python docs formatting fixes

Signed-off-by: Jacob Klegar <jacob@tecton.ai>

* lint

Signed-off-by: Jacob Klegar <jacob@tecton.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants