Infer entity dataframe event timestamp column #1495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
woop
reviewed
Apr 22, 2021
woop
reviewed
Apr 22, 2021
woop
reviewed
Apr 22, 2021
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
woop
reviewed
Apr 24, 2021
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
|
/lgtm |
woop
approved these changes
Apr 27, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jklegar, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
woop
pushed a commit
that referenced
this pull request
Apr 27, 2021
* Infer entity df event timestamp Signed-off-by: Jacob Klegar <jacob@tecton.ai> * Simplify inference of BQ Signed-off-by: Jacob Klegar <jacob@tecton.ai> * Address comment Signed-off-by: Jacob Klegar <jacob@tecton.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jacob Klegar jacob@tecton.ai
What this PR does / why we need it: If no column with the name "event_timestamp" exists, check if there is only one datetime column in the entity dataframe and if so, use it as the event timestamp column.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: