-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade grpcio version in python SDK #1508
Upgrade grpcio version in python SDK #1508
Conversation
@szalai1: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @szalai1. Thanks for your PR. I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: szalai1 <szalaipeti.vagyok@gmail.com>
c38842e
to
a531d0e
Compare
Question: This will cause a mismatch between the go grpcio version and the python one, shall I change that too? or just scratch my own itch. |
/ok-to-test |
Thanks @szalai1. Should we perhaps use a more relaxed version (like what Dagster does with I dont think it's necessary to update Go right now. I can't see a reason why they would be incompatible. |
thanks @woop for the quick review. Changed the version requirement. |
Signed-off-by: szalai1 <szalaipeti.vagyok@gmail.com>
959c047
to
e833750
Compare
/ok-to-test |
/kind housekeeping |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jklegar, szalai1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
* Upgrade grpcio version in python SDK Signed-off-by: szalai1 <szalaipeti.vagyok@gmail.com> * Set grpcio version requirements to >=1.32.0 Signed-off-by: szalai1 <szalaipeti.vagyok@gmail.com>
* Upgrade grpcio version in python SDK Signed-off-by: szalai1 <szalaipeti.vagyok@gmail.com> * Set grpcio version requirements to >=1.32.0 Signed-off-by: szalai1 <szalaipeti.vagyok@gmail.com>
What this PR does / why we need it:
Feast pins the grpcio dependency version to 1.31.0, which makes hard to use with other packages that requires higher version. (In our case it's Dagster , that requires >=1.32.0 )
This PR changes the grpcio version from 1.31.0 to 1.32. (Happy to change it even further)
Which issue(s) this PR fixes:
Haven't opened an issue, but happy to do if you want.
Fixes #
Does this PR introduce a user-facing change?:
NONE