Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a fixed timestamp to quickstart data #1513

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

jklegar
Copy link
Collaborator

@jklegar jklegar commented Apr 27, 2021

Signed-off-by: Jacob Klegar jacob@tecton.ai

What this PR does / why we need it: This ensures the get_historical_features call in the quickstart doesn't return NaNs

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Jacob Klegar <jacob@tecton.ai>
@jklegar
Copy link
Collaborator Author

jklegar commented Apr 27, 2021

/kind housekeeping

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jklegar, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Member

woop commented Apr 27, 2021

/lgtm

@feast-ci-bot feast-ci-bot merged commit b25ee3f into feast-dev:master Apr 27, 2021
woop pushed a commit that referenced this pull request Apr 27, 2021
Signed-off-by: Jacob Klegar <jacob@tecton.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants