Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump fastavro version #1585

Merged
merged 1 commit into from
Jun 11, 2021
Merged

Bump fastavro version #1585

merged 1 commit into from
Jun 11, 2021

Conversation

kevinhu
Copy link
Contributor

@kevinhu kevinhu commented May 25, 2021

What this PR does / why we need it:
Bumps fastavro
Which issue(s) this PR fixes:

Fixes #1584

Does this PR introduce a user-facing change?:

Bump fastavro version from '>=0.22.11,<0.23' to '>=1.1.0'

@feast-ci-bot
Copy link
Collaborator

Hi @kevinhu. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2021

Codecov Report

Merging #1585 (8f1fb38) into master (1fd030c) will not change coverage.
The diff coverage is n/a.

❗ Current head 8f1fb38 differs from pull request most recent head 6813f87. Consider uploading reports for the commit 6813f87 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1585   +/-   ##
=======================================
  Coverage   83.60%   83.60%           
=======================================
  Files          67       67           
  Lines        6027     6027           
=======================================
  Hits         5039     5039           
  Misses        988      988           
Flag Coverage Δ
integrationtests 83.52% <ø> (ø)
unittests 76.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/offline_stores/bigquery.py 92.48% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fd030c...6813f87. Read the comment docs.

@kevinhu kevinhu marked this pull request as ready for review May 25, 2021 22:37
@kevinhu kevinhu requested review from jklegar, tsotnet, woop and a team as code owners May 25, 2021 22:37
@kevinhu kevinhu requested a review from achals as a code owner June 11, 2021 02:54
@achals
Copy link
Member

achals commented Jun 11, 2021

@kevinhu could you address the DCO check and add a release note in the pr description? Looks good otherwise.

@kevinhu
Copy link
Contributor Author

kevinhu commented Jun 11, 2021

Done!

@achals
Copy link
Member

achals commented Jun 11, 2021

@kevinhu thanks for the release note and the PR! looks like DCO is still failing: https://github.com/feast-dev/feast/pull/1585/checks?check_run_id=2805507847 if you can address that we can get this merged in.

@kevinhu
Copy link
Contributor Author

kevinhu commented Jun 11, 2021

I think the check isn't running correctly – it seems that both the commits have been signed (including the one in question, 89aece1), but DCO isn't picking up on it.

@achals
Copy link
Member

achals commented Jun 11, 2021

I think the check isn't running correctly – it seems that both the commits have been signed (including the one in question, 89aece1), but DCO isn't picking up on it.

Hmmm, the commit in question doesn't seem to have the Signed-off-by like the other commit: 6813f87

image

image

Signed-off-by: Kevin Hu <kevinhuwest@gmail.com>
@kevinhu
Copy link
Contributor Author

kevinhu commented Jun 11, 2021

Fixed now

Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, kevinhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 68cacd9 into feast-dev:master Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump fastavro version
5 participants