-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump fastavro version #1585
Bump fastavro version #1585
Conversation
Hi @kevinhu. Thanks for your PR. I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #1585 +/- ##
=======================================
Coverage 83.60% 83.60%
=======================================
Files 67 67
Lines 6027 6027
=======================================
Hits 5039 5039
Misses 988 988
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@kevinhu could you address the DCO check and add a release note in the pr description? Looks good otherwise. |
Done! |
@kevinhu thanks for the release note and the PR! looks like DCO is still failing: https://github.com/feast-dev/feast/pull/1585/checks?check_run_id=2805507847 if you can address that we can get this merged in. |
I think the check isn't running correctly – it seems that both the commits have been signed (including the one in question, 89aece1), but DCO isn't picking up on it. |
Signed-off-by: Kevin Hu <kevinhuwest@gmail.com>
Fixed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, kevinhu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Bumps fastavro
Which issue(s) this PR fixes:
Fixes #1584
Does this PR introduce a user-facing change?: