Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition in historical e2e tests #1620

Merged
merged 1 commit into from
Jun 4, 2021

Conversation

woop
Copy link
Member

@woop woop commented Jun 4, 2021

Signed-off-by: Willem Pienaar git@willem.co

What this PR does / why we need it:

Fixes a race condition in historical retrieval (conflict in dataset name)

Which issue(s) this PR fixes:

Tries to fix https://github.com/feast-dev/feast/runs/2748222515

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Willem Pienaar <git@willem.co>
@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2021

Codecov Report

Merging #1620 (23f7422) into master (024737c) will decrease coverage by 5.79%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1620      +/-   ##
==========================================
- Coverage   83.64%   77.84%   -5.80%     
==========================================
  Files          67       66       -1     
  Lines        5814     5688     -126     
==========================================
- Hits         4863     4428     -435     
- Misses        951     1260     +309     
Flag Coverage Δ
integrationtests ?
unittests 77.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/tests/test_historical_retrieval.py 61.49% <ø> (-37.36%) ⬇️
sdk/python/tests/test_cli_gcp.py 40.74% <0.00%> (-59.26%) ⬇️
sdk/python/feast/infra/offline_stores/bigquery.py 32.41% <0.00%> (-58.63%) ⬇️
sdk/python/tests/utils/data_source_utils.py 51.85% <0.00%> (-48.15%) ⬇️
sdk/python/tests/test_feature_store.py 62.50% <0.00%> (-37.50%) ⬇️
sdk/python/tests/test_inference.py 73.91% <0.00%> (-26.09%) ⬇️
...hon/tests/test_offline_online_store_consistency.py 74.72% <0.00%> (-25.28%) ⬇️
sdk/python/feast/registry.py 59.55% <0.00%> (-19.56%) ⬇️
sdk/python/feast/data_source.py 69.13% <0.00%> (-9.65%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 024737c...23f7422. Read the comment docs.

Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@achals
Copy link
Member

achals commented Jun 4, 2021

/kind bug

@woop woop merged commit 8ac997c into feast-dev:master Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants