Add to_table() to RetrievalJob object #1663

MattDelac · 2021-06-23T13:45:37Z

What this PR does / why we need it:
We should add a notion of "OfflineJob" so that it will be easier to add new methods as well as accessible useful information.

For example, when you build a custom Provider, you might want to access the query coming from pull_latest_from_table_or_query() without executing it (as it will be executed differently)

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

pull_latest_from_table_or_query() now returns an RetrievalJob object
Add method to_table() to RetrievalJob object

codecov-commenter · 2021-06-23T13:47:42Z

Codecov Report

Merging #1663 (c378307) into master (b9dd955) will increase coverage by 0.02%.
The diff coverage is 92.50%.

@@            Coverage Diff             @@
##           master    #1663      +/-   ##
==========================================
+ Coverage   83.00%   83.02%   +0.02%     
==========================================
  Files          72       72              
  Lines        6377     6403      +26     
==========================================
+ Hits         5293     5316      +23     
- Misses       1084     1087       +3

Flag	Coverage Δ
integrationtests	`82.94% <92.50%> (+0.02%)`	⬆️
unittests	`71.54% <65.78%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
sdk/python/feast/feature_store.py	`93.07% <ø> (ø)`
sdk/python/feast/infra/provider.py	`88.88% <ø> (ø)`
...python/feast/infra/offline_stores/offline_store.py	`84.00% <75.00%> (-2.37%)`	⬇️
sdk/python/feast/infra/offline_stores/bigquery.py	`78.60% <90.00%> (+0.17%)`	⬆️
sdk/python/feast/infra/offline_stores/file.py	`96.96% <94.44%> (+0.12%)`	⬆️
sdk/python/feast/infra/gcp.py	`97.82% <100.00%> (+0.04%)`	⬆️
sdk/python/feast/infra/local.py	`90.19% <100.00%> (+0.19%)`	⬆️
sdk/python/tests/test_historical_retrieval.py	`98.96% <100.00%> (+0.02%)`	⬆️
sdk/python/feast/data_source.py	`66.41% <0.00%> (-0.33%)`	⬇️
...dk/python/tensorflow_metadata/proto/v0/path_pb2.py	`100.00% <0.00%> (ø)`
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9dd955...c378307. Read the comment docs.

woop · 2021-06-25T20:57:04Z

sdk/python/feast/infra/offline_stores/bigquery.py

+        self.client = _get_bigquery_client(project=config.offline_store.project_id)
+
+    def to_table(self) -> pyarrow.Table:
+        return self.client.query(self.query).to_arrow()


Is it intentional for BigQueryOfflineJob.to_table() to return a pyarrow table? I would have expected to_table() to create a BQ table. Would to_arrow_table() or to_arrow() be clearer?

woop · 2021-06-25T21:33:04Z

I really like this idea @MattDelac!

The one jarring thing is that we now have two types of jobs that are completely isolated. RetrievalJob and OfflineJob. Is there any reason for these to be different?

I like the idea of having a single OfflineJob that is configured differently through methods like materialize and get_historical_features() and context objects, and then you automatically get all the to_sql and other base functionality. The wrapping command (materialize, get_historical_features) can then work with the OfflineJob differently, like in one case it can use .to_table() or whatever if it needs to load the latest values into the online store.

What do you think about that?

MattDelac · 2021-06-28T15:58:50Z

The one jarring thing is that we now have two types of jobs that are completely isolated. RetrievalJob and OfflineJob. Is there any reason for these to be different?

Hmmm good question 🤔

I can see if those two objects could/should be the same

MattDelac · 2021-06-28T19:48:47Z

@woop I changed this PR to add a new method to the RetrievalJob object instead of creating a new object

Signed-off-by: Matt Delacour <matt.delacour@shopify.com>

woop · 2021-06-28T20:54:20Z

@woop I changed this PR to add a new method to the RetrievalJob object instead of creating a new object

Are you ready for a review?

MattDelac · 2021-06-28T21:09:43Z

@woop I changed this PR to add a new method to the RetrievalJob object instead of creating a new object

Are you ready for a review?

Let me check this linter issue since I rebased on master

Signed-off-by: Matt Delacour <matt.delacour@shopify.com>

MattDelac · 2021-06-28T21:24:49Z

@woop I changed this PR to add a new method to the RetrievalJob object instead of creating a new object

Are you ready for a review?

It sounds good now 👍

achals

looks good to me. Can we exercise this code path in the existing integration tests?

MattDelac · 2021-06-28T22:47:48Z

Can we exercise this code path in the existing integration tests?

Not sure I understand what you mean here ...

achals · 2021-06-28T23:04:23Z

Can we exercise this code path in the existing integration tests?

Not sure I understand what you mean here ...

Sorry, i meant can we call to_table during one of the integration tests?

woop · 2021-06-28T23:35:03Z

Also lgtm

Signed-off-by: Matt Delacour <matt.delacour@shopify.com>

achals

/lgtm

feast-ci-bot · 2021-06-29T02:15:54Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, MattDelac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [achals]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

woop · 2021-06-29T04:32:07Z

@achals @MattDelac I know we merged this, but I just realized that this comment was unaddressed #1663 (comment)

How do you feel about making the method to_arrow()?

Example in the wild https://googleapis.dev/python/bigquerystorage/latest/bigquery_storage_v1/library.html?highlight=arrow#google.cloud.bigquery_storage_v1.reader.ReadRowsIterable.to_arrow

MattDelac · 2021-06-29T10:33:07Z

@achals @MattDelac I know we merged this, but I just realized that this comment was unaddressed #1663 (comment)

How do you feel about making the method to_arrow()?

Example in the wild https://googleapis.dev/python/bigquerystorage/latest/bigquery_storage_v1/library.html?highlight=arrow#google.cloud.bigquery_storage_v1.reader.ReadRowsIterable.to_arrow

Ho sorry it's my fault. Will push a quick fix where I rename it to_arrow() 👍

* Add notion of OfflineJob Signed-off-by: Matt Delacour <matt.delacour@shopify.com> * Use RetrievalJob instead of creating a new OfflineJob object Signed-off-by: Matt Delacour <matt.delacour@shopify.com> * Add to_table() in integration tests Signed-off-by: Matt Delacour <matt.delacour@shopify.com> Co-authored-by: Tsotne Tabidze <tsotne@tecton.ai> Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com>

@tsotnet

…on to include feature view name in feature naming. (#1641) * test Signed-off-by: David Y Liu <davidyliuliu@gmail.com> Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com> * refactored existing tests to test full_feature_names feature on data retreival, added new tests also. Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com> * removed full_feature_names usage from quickstart and README to have more simple examples. Resolved failing tests. Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com> * Update CHANGELOG for Feast v0.10.8 Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com> * GitBook: [master] 2 pages modified Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com> * Schema Inferencing should happen at apply time (#1646) * wip1 Signed-off-by: David Y Liu <davidyliuliu@gmail.com> * just need to do clean up Signed-off-by: David Y Liu <davidyliuliu@gmail.com> * linted Signed-off-by: David Y Liu <davidyliuliu@gmail.com> * improve test coverage Signed-off-by: David Y Liu <davidyliuliu@gmail.com> * changed placement of inference methods in repo_operation apply_total Signed-off-by: David Y Liu <davidyliuliu@gmail.com> * updated inference method name + changed to void return since it updates in place Signed-off-by: David Y Liu <davidyliuliu@gmail.com> * fixed integration test and added comments Signed-off-by: David Y Liu <davidyliuliu@gmail.com> * Made DataSource event_timestamp_column optional Signed-off-by: David Y Liu <davidyliuliu@gmail.com> Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com> * GitBook: [master] 80 pages modified Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com> * GitBook: [master] 80 pages modified Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com> * Provide descriptive error on invalid table reference (#1627) * Initial commit to catch nonexistent table Signed-off-by: Cody Lin <codyjlin@yahoo.com> Signed-off-by: Cody Lin <codyl@twitter.com> * simplify nonexistent BQ table test Signed-off-by: Cody Lin <codyl@twitter.com> * clean up table_exists exception Signed-off-by: Cody Lin <codyl@twitter.com> * remove unneeded variable Signed-off-by: Cody Lin <codyl@twitter.com> * function name change to _assert_table_exists Signed-off-by: Cody Lin <codyl@twitter.com> * Initial commit to catch nonexistent table Signed-off-by: Cody Lin <codyjlin@yahoo.com> Signed-off-by: Cody Lin <codyl@twitter.com> * simplify nonexistent BQ table test Signed-off-by: Cody Lin <codyl@twitter.com> * clean up table_exists exception Signed-off-by: Cody Lin <codyl@twitter.com> * function name change to _assert_table_exists Signed-off-by: Cody Lin <codyl@twitter.com> * fix lint errors and rebase Signed-off-by: Cody Lin <codyl@twitter.com> * Fix get_table(None) error Signed-off-by: Cody Lin <codyl@twitter.com> * custom exception for both missing file and BQ source Signed-off-by: Cody Lin <codyl@twitter.com> * revert FileSource checks Signed-off-by: Cody Lin <codyl@twitter.com> * Use DataSourceNotFoundException instead of subclassing Signed-off-by: Cody Lin <codyl@twitter.com> * Moved assert_table_exists out of the BQ constructor to apply_total Signed-off-by: Cody Lin <codyl@twitter.com> * rename test and test asset Signed-off-by: Cody Lin <codyl@twitter.com> * move validate logic back to data_source Signed-off-by: Cody Lin <codyl@twitter.com> * fixed tests Signed-off-by: Cody Lin <codyl@twitter.com> * Set pytest.integration for tests that access BQ Signed-off-by: Cody Lin <codyl@twitter.com> * Import pytest in failed test files Signed-off-by: Cody Lin <codyl@twitter.com> Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com> * Refactor OnlineStoreConfig classes into owning modules (#1649) * Refactor OnlineStoreConfig classes into owning modules Signed-off-by: Achal Shah <achals@gmail.com> * make format Signed-off-by: Achal Shah <achals@gmail.com> * Move redis too Signed-off-by: Achal Shah <achals@gmail.com> * update test_telemetery Signed-off-by: Achal Shah <achals@gmail.com> * add a create_repo_config method that should be called instead of RepoConfig ctor directly Signed-off-by: Achal Shah <achals@gmail.com> * fix the table reference in repo_operations Signed-off-by: Achal Shah <achals@gmail.com> * reuse create_repo_config Signed-off-by: Achal Shah <achals@gmail.com> Remove redis provider reference * CR comments Signed-off-by: Achal Shah <achals@gmail.com> * Remove create_repo_config in favor of __init__ Signed-off-by: Achal Shah <achals@gmail.com> * make format Signed-off-by: Achal Shah <achals@gmail.com> * Remove print statement Signed-off-by: Achal Shah <achals@gmail.com> Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com> * Possibility to specify a project for BigQuery queries (#1656) Signed-off-by: Matt Delacour <matt.delacour@shopify.com> Co-authored-by: Achal Shah <achals@gmail.com> Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com> * Refactor OfflineStoreConfig classes into their owning modules (#1657) * Refactor OfflineStoreConfig classes into their owning modules Signed-off-by: Achal Shah <achals@gmail.com> * Fix error string Signed-off-by: Achal Shah <achals@gmail.com> * Generic error class Signed-off-by: Achal Shah <achals@gmail.com> * Merge conflicts Signed-off-by: Achal Shah <achals@gmail.com> * make the store type work, and add a test that uses the fully qualified name of the OnlineStore Signed-off-by: Achal Shah <achals@gmail.com> * Address comments from previous PR Signed-off-by: Achal Shah <achals@gmail.com> * CR updates Signed-off-by: Achal Shah <achals@gmail.com> Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com> * Run python unit tests in parallel (#1652) Signed-off-by: Achal Shah <achals@gmail.com> Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com> * Rename telemetry to usage (#1660) * Rename telemetry to usage Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai> * Update docs Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai> * Update .prow and infra Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai> * Rename file Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai> * Change url Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai> * Re-add telemetry.md for backwards-compatibility Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai> Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com> * resolved final comments on PR (variable renaming, refactor tests) Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com> * reformatted after merge conflict Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com> * Update CHANGELOG for Feast v0.11.0 Signed-off-by: Willem Pienaar <git@willem.co> Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com> * Update charts README (#1659) Adding feast jupyter link to it. + Fix the helm 'feast-serving' name in aws/azure terraform. Signed-off-by: szalai1 <szalaipeti.vagyok@gmail.com> Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com> * Added Redis to list of online stores for local provider in providers reference doc. (#1668) Signed-off-by: Nel Swanepoel <c.swanepoel@ucl.ac.uk> Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com> * Grouped inferencing statements together in apply methods for easier readability (#1667) * grouped inferencing statements together Signed-off-by: David Y Liu <davidyliuliu@gmail.com> * update in testing Signed-off-by: David Y Liu <davidyliuliu@gmail.com> Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com> * Add RedshiftDataSource (#1669) * Add RedshiftDataSource Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai> * Call parent __init__ first Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai> Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com> * Provide the user with more options for setting the to_bigquery config (#1661) * Provide more options for to_bigquery config Signed-off-by: Cody Lin <codyl@twitter.com> * Fix default job_config when none; remove excessive testing Signed-off-by: Cody Lin <codyl@twitter.com> * Add param type and docstring Signed-off-by: Cody Lin <codyl@twitter.com> * add docstrings and typing Signed-off-by: Cody Lin <codyl@twitter.com> * Apply docstring suggestions from code review Co-authored-by: Willem Pienaar <6728866+woop@users.noreply.github.com> Signed-off-by: Cody Lin <codyjlin@yahoomail.com> Co-authored-by: Willem Pienaar <6728866+woop@users.noreply.github.com> Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com> * Add streaming sources to the FeatureView API (#1664) * Add a streaming source to the FeatureView API This diff only updates the API. It is currently up to the providers to actually use this information to spin up resources to consume events from the stream sources. Signed-off-by: Achal Shah <achals@gmail.com> * remove stuff from rebase Signed-off-by: Achal Shah <achals@gmail.com> * make format Signed-off-by: Achal Shah <achals@gmail.com> * Update protos Signed-off-by: Achal Shah <achals@gmail.com> * lint Signed-off-by: Achal Shah <achals@gmail.com> * format Signed-off-by: Achal Shah <achals@gmail.com> * CR Signed-off-by: Achal Shah <achals@gmail.com> * fix test Signed-off-by: Achal Shah <achals@gmail.com> * lint Signed-off-by: Achal Shah <achals@gmail.com> Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com> * Add to_table() to RetrievalJob object (#1663) * Add notion of OfflineJob Signed-off-by: Matt Delacour <matt.delacour@shopify.com> * Use RetrievalJob instead of creating a new OfflineJob object Signed-off-by: Matt Delacour <matt.delacour@shopify.com> * Add to_table() in integration tests Signed-off-by: Matt Delacour <matt.delacour@shopify.com> Co-authored-by: Tsotne Tabidze <tsotne@tecton.ai> Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com> * Rename to_table to to_arrow (#1671) Signed-off-by: Matt Delacour <matt.delacour@shopify.com> Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com> * Cancel BigQuery job if timeout hits (#1672) * Cancel BigQuery job if timedout hits Signed-off-by: Matt Delacour <matt.delacour@shopify.com> * Fix typo Signed-off-by: Matt Delacour <matt.delacour@shopify.com> Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com> * Fix Feature References example (#1674) Fix Feature References example by passing `entity_rows` to `get_online_features()` Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com> * Allow strings for online/offline store instead of dicts (#1673) Signed-off-by: Achal Shah <achals@gmail.com> Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com> * Remove default list from the FeatureView constructor (#1679) Signed-off-by: Achal Shah <achals@gmail.com> Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com> * made changes requested by @tsotnet Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com> * Fix unit tests that got broken by Pandas 1.3.0 release (#1683) Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai> Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com> * Add support for DynamoDB and S3 registry (#1483) * Add support for DynamoDB and S3 registry Signed-off-by: lblokhin <lenin133@yandex.ru> * rcu and wcu as a parameter of dynamodb online store Signed-off-by: lblokhin <lenin133@yandex.ru> * fix linter Signed-off-by: lblokhin <lenin133@yandex.ru> * aws dependency to extras Signed-off-by: lblokhin <lenin133@yandex.ru> * FEAST_S3_ENDPOINT_URL Signed-off-by: lblokhin <lenin133@yandex.ru> * tests Signed-off-by: lblokhin <lenin133@yandex.ru> * fix signature, after merge Signed-off-by: lblokhin <lenin133@yandex.ru> * aws default region name configurable Signed-off-by: lblokhin <lenin133@yandex.ru> * add offlinestore config type to test Signed-off-by: lblokhin <lenin133@yandex.ru> * review changes Signed-off-by: lblokhin <lenin133@yandex.ru> * review requested changes Signed-off-by: lblokhin <lenin133@yandex.ru> * integration test for Dynamo Signed-off-by: lblokhin <lenin133@yandex.ru> * change the rest of table_name to table_instance (where table_name is actually an instance of DynamoDB Table object) Signed-off-by: lblokhin <lenin133@yandex.ru> * fix DynamoDBOnlineStore commit Signed-off-by: lblokhin <lenin133@yandex.ru> * move client to _initialize_dynamodb Signed-off-by: lblokhin <lenin133@yandex.ru> * rename document_id to entity_id and Row to entity_id Signed-off-by: lblokhin <lenin133@yandex.ru> * The default value is None Signed-off-by: lblokhin <lenin133@yandex.ru> * Remove Datastore from the docstring. Signed-off-by: lblokhin <lenin133@yandex.ru> * get rid of the return call from S3RegistryStore Signed-off-by: lblokhin <lenin133@yandex.ru> * merge two exceptions Signed-off-by: lblokhin <lenin133@yandex.ru> * For ci requirement Signed-off-by: lblokhin <lenin133@yandex.ru> * remove configuration from test Signed-off-by: lblokhin <lenin133@yandex.ru> * feast-integration-tests for tests Signed-off-by: lblokhin <lenin133@yandex.ru> * change test path Signed-off-by: lblokhin <lenin133@yandex.ru> * add fixture feature_store_with_s3_registry to test Signed-off-by: lblokhin <lenin133@yandex.ru> * region required Signed-off-by: lblokhin <lenin133@yandex.ru> * Address the rest of the comments Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai> * Update to_table to to_arrow Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai> Co-authored-by: Tsotne Tabidze <tsotne@tecton.ai> Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com> * Parallelize integration tests (#1684) * Parallelize integration tests Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai> * Update the usage flag Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai> Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com> * BQ exception should be raised first before we check the timedout (#1675) Signed-off-by: Matt Delacour <matt.delacour@shopify.com> Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com> * Update sdk/python/feast/infra/provider.py Co-authored-by: Willem Pienaar <6728866+woop@users.noreply.github.com> Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com> * Update sdk/python/feast/feature_store.py Co-authored-by: Willem Pienaar <6728866+woop@users.noreply.github.com> Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com> * made error logic/messages more descriptive Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com> * made error logic/messages more descriptive. Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com> * Simplified error messages Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com> * ran formatter, issue in errors.py Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com> * python linter issues resolved Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com> * removed unnecessary default assignment in get_historical_features. default now set only in feature_store.py Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com> * added error message assertion for feature name collisions, and other nitpick changes Signed-off-by: Mwad22 <51929507+Mwad22@users.noreply.github.com> Co-authored-by: David Y Liu <davidyliuliu@gmail.com> Co-authored-by: Tsotne Tabidze <tsotne@tecton.ai> Co-authored-by: Achal Shah <achals@gmail.com> Co-authored-by: David Y Liu <7172604+mavysavydav@users.noreply.github.com> Co-authored-by: Willem Pienaar <github@willem.co> Co-authored-by: codyjlin <31944154+codyjlin@users.noreply.github.com> Co-authored-by: Matt Delacour <MattDelac@users.noreply.github.com> Co-authored-by: Willem Pienaar <git@willem.co> Co-authored-by: Peter Szalai <szalaipeti.vagyok@gmail.com> Co-authored-by: Nel Swanepoel <nels@users.noreply.github.com> Co-authored-by: Willem Pienaar <6728866+woop@users.noreply.github.com> Co-authored-by: Greg Kuhlmann <greg.kuhlmann@gmail.com> Co-authored-by: Leonid <lenin133@yandex.ru>

MattDelac requested review from achals, tsotnet, woop and a team as code owners June 23, 2021 13:45

feast-ci-bot added release-note needs-kind size/L labels Jun 23, 2021

MattDelac force-pushed the fix_bq_project_properly branch from 8e9cd62 to 1fae81e Compare June 23, 2021 13:46

MattDelac added kind/feature New feature or request ok-to-test labels Jun 23, 2021

feast-ci-bot removed the needs-kind label Jun 23, 2021

MattDelac changed the title ~~Fix bq project properly~~ Add OfflineJob object Jun 23, 2021

woop reviewed Jun 25, 2021

View reviewed changes

Add notion of OfflineJob

9df3864

Signed-off-by: Matt Delacour <matt.delacour@shopify.com>

MattDelac force-pushed the fix_bq_project_properly branch from 22ae256 to d37e6a0 Compare June 28, 2021 19:51

MattDelac force-pushed the fix_bq_project_properly branch from d37e6a0 to b55f7cc Compare June 28, 2021 21:09

Use RetrievalJob instead of creating a new OfflineJob object

fa5551b

Signed-off-by: Matt Delacour <matt.delacour@shopify.com>

MattDelac force-pushed the fix_bq_project_properly branch from b55f7cc to fa5551b Compare June 28, 2021 21:15

MattDelac changed the title ~~Add OfflineJob object~~ Add to_table() RetrievalJob object Jun 28, 2021

MattDelac changed the title ~~Add to_table() RetrievalJob object~~ Add to_table() to RetrievalJob object Jun 28, 2021

achals reviewed Jun 28, 2021

View reviewed changes

Add to_table() in integration tests

c378307

Signed-off-by: Matt Delacour <matt.delacour@shopify.com>

achals approved these changes Jun 29, 2021

View reviewed changes

feast-ci-bot assigned achals Jun 29, 2021

feast-ci-bot added the lgtm label Jun 29, 2021

feast-ci-bot added the approved label Jun 29, 2021

feast-ci-bot merged commit 5a49470 into feast-dev:master Jun 29, 2021

MattDelac deleted the fix_bq_project_properly branch June 29, 2021 10:32

MattDelac mentioned this pull request Jun 29, 2021

Rename to_table to to_arrow #1671

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add to_table() to RetrievalJob object #1663

Add to_table() to RetrievalJob object #1663

MattDelac commented Jun 23, 2021 •

edited

Loading

codecov-commenter commented Jun 23, 2021 •

edited

Loading

woop Jun 25, 2021 •

edited

Loading

woop commented Jun 25, 2021

MattDelac commented Jun 28, 2021

MattDelac commented Jun 28, 2021

woop commented Jun 28, 2021

MattDelac commented Jun 28, 2021

MattDelac commented Jun 28, 2021

achals left a comment

MattDelac commented Jun 28, 2021

achals commented Jun 28, 2021

woop commented Jun 28, 2021

achals left a comment

feast-ci-bot commented Jun 29, 2021

woop commented Jun 29, 2021 •

edited

Loading

MattDelac commented Jun 29, 2021

Add to_table() to RetrievalJob object #1663

Add to_table() to RetrievalJob object #1663

Conversation

MattDelac commented Jun 23, 2021 • edited Loading

codecov-commenter commented Jun 23, 2021 • edited Loading

Codecov Report

woop Jun 25, 2021 • edited Loading

Choose a reason for hiding this comment

woop commented Jun 25, 2021

MattDelac commented Jun 28, 2021

MattDelac commented Jun 28, 2021

woop commented Jun 28, 2021

MattDelac commented Jun 28, 2021

MattDelac commented Jun 28, 2021

achals left a comment

Choose a reason for hiding this comment

MattDelac commented Jun 28, 2021

achals commented Jun 28, 2021

woop commented Jun 28, 2021

achals left a comment

Choose a reason for hiding this comment

feast-ci-bot commented Jun 29, 2021

woop commented Jun 29, 2021 • edited Loading

MattDelac commented Jun 29, 2021

MattDelac commented Jun 23, 2021 •

edited

Loading

codecov-commenter commented Jun 23, 2021 •

edited

Loading

woop Jun 25, 2021 •

edited

Loading

woop commented Jun 29, 2021 •

edited

Loading