Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove debug logging #1678

Merged
merged 2 commits into from
Jul 7, 2021
Merged

Conversation

8bit-pixies
Copy link
Contributor

What this PR does / why we need it:
Fixes a typo
Which issue(s) this PR fixes:

Does this PR introduce a user-facing change?:

None

@feast-ci-bot
Copy link
Collaborator

Hi @chappers. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@8bit-pixies 8bit-pixies changed the title fix typo fix typo soruce --> source Jul 1, 2021
@achals achals changed the title fix typo soruce --> source Remove debug logging Jul 1, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2021

Codecov Report

Merging #1678 (05844d9) into master (4d0ea72) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1678      +/-   ##
==========================================
- Coverage   82.56%   82.48%   -0.08%     
==========================================
  Files          76       76              
  Lines        6698     6697       -1     
==========================================
- Hits         5530     5524       -6     
- Misses       1168     1173       +5     
Flag Coverage Δ
integrationtests 82.48% <ø> (-0.01%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/feature_view.py 85.12% <ø> (-0.13%) ⬇️
sdk/python/tests/conftest.py 83.87% <0.00%> (-16.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d0ea72...05844d9. Read the comment docs.

@achals
Copy link
Member

achals commented Jul 2, 2021

looks good to me, you may have to address the DCO check that's currently failing.

@woop
Copy link
Member

woop commented Jul 5, 2021

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: charliec443, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@achals
Copy link
Member

achals commented Jul 6, 2021

@charliec443 you may need to rebase your changes, I think there was a pandas version fix that would solve the test failures

@feast-ci-bot feast-ci-bot removed the lgtm label Jul 6, 2021
Signed-off-by: Chapman Siu <chapm0n.siu@gmail.com>
Signed-off-by: Chapman Siu <chapm0n.siu@gmail.com>
@8bit-pixies
Copy link
Contributor Author

@achals thanks for following up - I have rebased.

@achals
Copy link
Member

achals commented Jul 7, 2021

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants