-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove debug logging #1678
Remove debug logging #1678
Conversation
Hi @chappers. Thanks for your PR. I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #1678 +/- ##
==========================================
- Coverage 82.56% 82.48% -0.08%
==========================================
Files 76 76
Lines 6698 6697 -1
==========================================
- Hits 5530 5524 -6
- Misses 1168 1173 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
looks good to me, you may have to address the DCO check that's currently failing. |
3ab8471
to
b24a2d5
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: charliec443, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@charliec443 you may need to rebase your changes, I think there was a pandas version fix that would solve the test failures |
Signed-off-by: Chapman Siu <chapm0n.siu@gmail.com>
05844d9
to
f6cedec
Compare
@achals thanks for following up - I have rebased. |
/lgtm |
What this PR does / why we need it:
Fixes a typo
Which issue(s) this PR fixes:
Does this PR introduce a user-facing change?: