-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update redis options parsing #1704
Conversation
Hi @DvirDukhan. Thanks for your PR. I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #1704 +/- ##
==========================================
+ Coverage 82.75% 83.45% +0.70%
==========================================
Files 76 76
Lines 6754 7291 +537
==========================================
+ Hits 5589 6085 +496
- Misses 1165 1206 +41
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Thanks for the contribution @DvirDukhan! Looks good to me, do you mind fixing lint and adding a unit test, and then we can get this merged in? |
@achals thanks for the review |
6a76af1
to
81b8a1c
Compare
The Redis connection string is a comma-separated string, where each additional parameter in addition to host and port is in the format `key=value`. This proposal fixing the parsing in cases where the parameter values contain the `=` symbol, for example `localhost:6379,password=my=password` Signed-off-by: DvirDukhan <dvir@redislabs.com>
Signed-off-by: DvirDukhan <dvir@redislabs.com>
@DvirDukhan you should be able to run |
done, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, DvirDukhan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest |
* Update redis.py The Redis connection string is a comma-separated string, where each additional parameter in addition to host and port is in the format `key=value`. This proposal fixing the parsing in cases where the parameter values contain the `=` symbol, for example `localhost:6379,password=my=password` Signed-off-by: DvirDukhan <dvir@redislabs.com> * added test Signed-off-by: DvirDukhan <dvir@redislabs.com> * format Signed-off-by: DvirDukhan <dvir@redislabs.com> Signed-off-by: CS <2498638+charliec443@users.noreply.github.com>
What this PR does / why we need it:
The Redis connection string is a comma-separated string, where each additional parameter in addition to host and port is in the format
key=value
.This proposal fixing the parsing in cases where the parameter values contain the
=
symbol, for examplelocalhost:6379,password=my=password
Which issue(s) this PR fixes:
None
Does this PR introduce a user-facing change?: