Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update redis options parsing #1704

Merged
merged 3 commits into from
Jul 14, 2021
Merged

Conversation

DvirDukhan
Copy link
Collaborator

What this PR does / why we need it:
The Redis connection string is a comma-separated string, where each additional parameter in addition to host and port is in the format key=value.
This proposal fixing the parsing in cases where the parameter values contain the = symbol, for example localhost:6379,password=my=password

Which issue(s) this PR fixes:

None

Does this PR introduce a user-facing change?:

NONE

@feast-ci-bot
Copy link
Collaborator

Hi @DvirDukhan. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2021

Codecov Report

Merging #1704 (dabb549) into master (0d0492d) will increase coverage by 0.70%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1704      +/-   ##
==========================================
+ Coverage   82.75%   83.45%   +0.70%     
==========================================
  Files          76       76              
  Lines        6754     7291     +537     
==========================================
+ Hits         5589     6085     +496     
- Misses       1165     1206      +41     
Flag Coverage Δ
integrationtests 83.24% <100.00%> (+0.57%) ⬆️
unittests 69.61% <17.64%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/online_stores/redis.py 94.64% <100.00%> (+2.67%) ⬆️
sdk/python/tests/test_cli_redis.py 100.00% <100.00%> (ø)
...hon/tests/test_offline_online_store_consistency.py 91.86% <0.00%> (-8.14%) ⬇️
sdk/python/feast/feature_store.py 94.03% <0.00%> (-0.41%) ⬇️
sdk/python/feast/infra/online_stores/sqlite.py 97.59% <0.00%> (+1.20%) ⬆️
sdk/python/feast/entity.py 97.63% <0.00%> (+1.26%) ⬆️
sdk/python/feast/registry.py 81.29% <0.00%> (+1.36%) ⬆️
sdk/python/feast/infra/local.py 92.15% <0.00%> (+1.96%) ⬆️
sdk/python/tests/feast_serving_server.py 43.33% <0.00%> (+2.02%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d0492d...dabb549. Read the comment docs.

@achals
Copy link
Member

achals commented Jul 12, 2021

Thanks for the contribution @DvirDukhan! Looks good to me, do you mind fixing lint and adding a unit test, and then we can get this merged in?

@DvirDukhan
Copy link
Collaborator Author

@achals thanks for the review
sure, I will supply unit test soon

@DvirDukhan DvirDukhan force-pushed the patch-1 branch 2 times, most recently from 6a76af1 to 81b8a1c Compare July 12, 2021 22:36
The Redis connection string is a comma-separated string, where each additional parameter in addition to host and port is in the format `key=value`.
This proposal fixing the parsing in cases where the parameter values contain the `=` symbol, for example `localhost:6379,password=my=password`

Signed-off-by: DvirDukhan <dvir@redislabs.com>
Signed-off-by: DvirDukhan <dvir@redislabs.com>
@achals
Copy link
Member

achals commented Jul 13, 2021

@DvirDukhan you should be able to run make format to fix the linter failure

Signed-off-by: DvirDukhan <dvir@redislabs.com>
@DvirDukhan
Copy link
Collaborator Author

done, thanks

Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, DvirDukhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@achals achals changed the title Update redis.py Update redis options parsing to handle values with = Jul 14, 2021
@achals
Copy link
Member

achals commented Jul 14, 2021

/retest

@achals achals changed the title Update redis options parsing to handle values with = Update redis options parsing Jul 14, 2021
@achals
Copy link
Member

achals commented Jul 14, 2021

/retest

@feast-ci-bot feast-ci-bot merged commit 703c4be into feast-dev:master Jul 14, 2021
8bit-pixies pushed a commit to 8bit-pixies/feast that referenced this pull request Jul 16, 2021
* Update redis.py

The Redis connection string is a comma-separated string, where each additional parameter in addition to host and port is in the format `key=value`.
This proposal fixing the parsing in cases where the parameter values contain the `=` symbol, for example `localhost:6379,password=my=password`

Signed-off-by: DvirDukhan <dvir@redislabs.com>

* added test

Signed-off-by: DvirDukhan <dvir@redislabs.com>

* format

Signed-off-by: DvirDukhan <dvir@redislabs.com>
Signed-off-by: CS <2498638+charliec443@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants