Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add randomness to bigquery table name #1711

Merged
merged 1 commit into from
Jul 13, 2021

Conversation

felixwang9817
Copy link
Collaborator

@felixwang9817 felixwang9817 commented Jul 13, 2021

Signed-off-by: Felix Wang wangfelix98@gmail.com

What this PR does / why we need it: Fixes a bug in the test_timestamp_bound_inference_from_entity_df_using_bigquery integration test where different runs of the test would point to the same BQ table, resulting in errors.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2021

Codecov Report

Merging #1711 (cf243c8) into master (5957da2) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1711   +/-   ##
=======================================
  Coverage   82.75%   82.75%           
=======================================
  Files          76       76           
  Lines        6754     6754           
=======================================
  Hits         5589     5589           
  Misses       1165     1165           
Flag Coverage Δ
integrationtests 82.67% <100.00%> (ø)
unittests 69.73% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/tests/test_historical_retrieval.py 99.09% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5957da2...cf243c8. Read the comment docs.

@felixwang9817 felixwang9817 changed the title Add randomness to bigquery table name to ensure the same table does n… Add randomness to bigquery table name Jul 13, 2021
@feast-ci-bot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@feast-ci-bot feast-ci-bot removed the lgtm label Jul 13, 2021
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@achals achals added the lgtm label Jul 13, 2021
@feast-ci-bot feast-ci-bot merged commit a609ace into feast-dev:master Jul 13, 2021
@felixwang9817 felixwang9817 deleted the fix_bq_test branch July 13, 2021 23:30
8bit-pixies pushed a commit to 8bit-pixies/feast that referenced this pull request Jul 16, 2021
…east-dev#1711)

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: CS <2498638+charliec443@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants