Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registry teardown #1718

Merged
merged 7 commits into from
Jul 22, 2021
Merged

Conversation

felixwang9817
Copy link
Collaborator

What this PR does / why we need it: As of right now, registries do not get cleaned up during teardown. This is especially bad for GCS and S3 registries. This PR ensures that registries get cleaned up during teardown.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2021

Codecov Report

Merging #1718 (92c66c6) into master (13645c1) will increase coverage by 0.13%.
The diff coverage is 85.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1718      +/-   ##
==========================================
+ Coverage   78.66%   78.80%   +0.13%     
==========================================
  Files          77       77              
  Lines        6502     6529      +27     
==========================================
+ Hits         5115     5145      +30     
+ Misses       1387     1384       -3     
Flag Coverage Δ
integrationtests 78.72% <85.41%> (+0.13%) ⬆️
unittests 62.24% <52.08%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/repo_operations.py 32.50% <33.33%> (+1.43%) ⬆️
sdk/python/feast/registry.py 79.86% <73.68%> (-0.96%) ⬇️
sdk/python/feast/feature_store.py 94.71% <100.00%> (+0.33%) ⬆️
...alization/test_offline_online_store_consistency.py 100.00% <100.00%> (ø)
...gration/offline_store/test_historical_retrieval.py 99.09% <100.00%> (+<0.01%) ⬆️
...sts/integration/registration/test_feature_store.py 100.00% <100.00%> (ø)
...on/tests/integration/registration/test_registry.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13645c1...92c66c6. Read the comment docs.

@felixwang9817
Copy link
Collaborator Author

/retest

sdk/python/feast/registry.py Outdated Show resolved Hide resolved
sdk/python/feast/registry.py Outdated Show resolved Hide resolved
sdk/python/feast/registry.py Outdated Show resolved Hide resolved
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 4e6a3f7 into feast-dev:master Jul 22, 2021
@felixwang9817 felixwang9817 deleted the registry_teardown branch July 22, 2021 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants