-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unit test warnings related to file_url #1726
Conversation
Hi @tedhtchang. Thanks for your PR. I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #1726 +/- ##
==========================================
+ Coverage 78.66% 78.77% +0.10%
==========================================
Files 77 77
Lines 6502 6529 +27
==========================================
+ Hits 5115 5143 +28
+ Misses 1387 1386 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: ted chang <htchang@us.ibm.com>
26c919c
to
89ac9db
Compare
/cc @achals |
Thanks @tedhtchang ! Looks good to me. The PR title mentions pandas.utils.testing but I don't see any changes related to that here? |
Sorry I changed it. The title was old. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, tedhtchang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: ted chang htchang@us.ibm.com
What this PR does / why we need it:
Fix the test warning feast/sdk/python/feast/infra/offline_stores/file_source.py:48: UserWarning: Argument "file_url" is being deprecated. Please use the "path" argument.
Does this PR introduce a user-facing change?: