Fix GCS version #1732
Fix GCS version #1732
Conversation
potatochip
requested review from
achals,
tsotnet,
woop and
a team
as code owners
|
Hi @potatochip. Thanks for your PR. I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
feast-ci-bot
added
size/XS
release-note-none
and removed
do-not-merge/release-note-label-needed
labels
|
Thanks @potatochip! |
Codecov Report
@@ Coverage Diff @@
## master #1732 +/- ##
=======================================
Coverage 79.06% 79.06%
=======================================
Files 80 80
Lines 6849 6849
=======================================
Hits 5415 5415
Misses 1434 1434
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
Thanks @potatochip! DCO is the only thing that needs to be fixed (https://github.com/feast-dev/feast/pull/1732/checks?check_run_id=3146041885) otherwise this is good to merge. |
In feast.registry.Registy.get_registry_proto the gcs method `download_blob_to_file` is called with the timeout param which does not exist until version 1.34. Signed-off-by: Aaron Mangum <aaron.mangum@iherb.com>
potatochip
force-pushed
the
bugfix/gsc-version-timeout-arg
branch
from
3b0aa4d
to
2e48a68
Compare
|
Updated DCO |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, potatochip The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
What this PR does / why we need it:
In feast.registry.Registy.get_registry_proto the gcs method
download_blob_to_fileis called with the timeout param which does notexist until version 1.34.
Which issue(s) this PR fixes:
n/a
Does this PR introduce a user-facing change?:
No.