Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add online feature retrieval integration test using the universal repo #1783

Merged

Conversation

achals
Copy link
Member

@achals achals commented Aug 16, 2021

Signed-off-by: Achal Shah achals@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2021

Codecov Report

Merging #1783 (ec9fdd1) into master (351b913) will increase coverage by 0.32%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1783      +/-   ##
==========================================
+ Coverage   85.20%   85.53%   +0.32%     
==========================================
  Files          87       88       +1     
  Lines        6501     6656     +155     
==========================================
+ Hits         5539     5693     +154     
- Misses        962      963       +1     
Flag Coverage Δ
integrationtests 85.45% <100.00%> (+0.33%) ⬆️
unittests 63.52% <26.22%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ation/feature_repos/universal/data_sources/file.py 100.00% <ø> (ø)
...tegration/feature_repos/universal/feature_views.py 100.00% <ø> (ø)
...tegration/feature_repos/test_repo_configuration.py 100.00% <100.00%> (ø)
.../integration/online_store/test_universal_online.py 100.00% <100.00%> (ø)
sdk/python/feast/feature_view.py 87.05% <0.00%> (-0.72%) ⬇️
sdk/python/feast/feature_store.py 92.90% <0.00%> (-0.68%) ⬇️
.../tests/integration/scaffolding/test_repo_config.py 100.00% <0.00%> (ø)
sdk/python/feast/repo_config.py 92.96% <0.00%> (+0.34%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 351b913...ec9fdd1. Read the comment docs.

Signed-off-by: Achal Shah <achals@gmail.com>
adchia
adchia previously requested changes Aug 17, 2021
Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Signed-off-by: Achal Shah <achals@gmail.com>
@feast-ci-bot feast-ci-bot removed the lgtm label Aug 17, 2021
@adchia
Copy link
Collaborator

adchia commented Aug 17, 2021

/lgtm

@adchia adchia dismissed their stale review August 17, 2021 19:31

unintentional change requested

@feast-ci-bot feast-ci-bot merged commit da436b5 into feast-dev:master Aug 17, 2021
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@achals achals deleted the achal/integration-tests-3-online branch August 17, 2021 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants