-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Azure Terraform installation. #1793
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mmurdoch The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @mmurdoch. Thanks for your PR. I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #1793 +/- ##
===========================================
- Coverage 85.35% 63.54% -21.82%
===========================================
Files 88 85 -3
Lines 6584 6498 -86
===========================================
- Hits 5620 4129 -1491
- Misses 964 2369 +1405
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Helm chart for Feast in the Terraform installation changed to point to the location referenced in the Azure Helm installation documentation (https://docs.feast.dev/feast-on-kubernetes-1/getting-started/install-feast/kubernetes-azure-aks-with-helm) Fixes issue 1792 Signed-off-by: Matthew Murdoch <matthew.murdoch.0@gmail.com>
Thanks @mmurdoch |
Helm chart for Feast in the Terraform installation changed to
point to the location referenced in the Azure Helm installation
documentation (https://docs.feast.dev/feast-on-kubernetes-1/getting-started/install-feast/kubernetes-azure-aks-with-helm)
Which issue(s) this PR fixes:
Fixes #1792
Does this PR introduce a user-facing change?: