Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename telemetry to usage #1800

Merged
merged 1 commit into from
Aug 25, 2021

Conversation

felixwang9817
Copy link
Collaborator

Signed-off-by: Felix Wang wangfelix98@gmail.com

What this PR does / why we need it: A few places in the codebase still refer to telemetry. This PR renames "telemetry" to "usage".

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@felixwang9817
Copy link
Collaborator Author

/kind housekeeping

@woop
Copy link
Member

woop commented Aug 25, 2021

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: felixwang9817, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

Codecov Report

Merging #1800 (760e70a) into master (cf488dc) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1800   +/-   ##
=======================================
  Coverage   84.85%   84.85%           
=======================================
  Files          92       92           
  Lines        6826     6826           
=======================================
  Hits         5792     5792           
  Misses       1034     1034           
Flag Coverage Δ
integrationtests 84.77% <100.00%> (ø)
unittests 63.93% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/usage.py 60.95% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf488dc...760e70a. Read the comment docs.

@feast-ci-bot feast-ci-bot merged commit 5e61a6f into feast-dev:master Aug 25, 2021
@felixwang9817 felixwang9817 deleted the rename_telemetry branch August 25, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants