Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Redshift query for external tables #1810

Merged
merged 1 commit into from
Aug 30, 2021

Conversation

woop
Copy link
Member

@woop woop commented Aug 27, 2021

Signed-off-by: Willem Pienaar git@willem.co

What this PR does / why we need it:

Currently it's not possible to use ANY_VALUE with Redshift Spectrum (when querying features on S3). This PR changes ANY_VALUE to MAX

Does this PR introduce a user-facing change?:

Fixed a bug in Redshift training dataset generation where queries failed on external tables

Signed-off-by: Willem Pienaar <git@willem.co>
@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2021

Codecov Report

Merging #1810 (fb316e4) into master (998e169) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1810      +/-   ##
==========================================
- Coverage   84.85%   84.81%   -0.05%     
==========================================
  Files          92       92              
  Lines        6828     6828              
==========================================
- Hits         5794     5791       -3     
- Misses       1034     1037       +3     
Flag Coverage Δ
integrationtests 84.76% <ø> (-0.02%) ⬇️
unittests 63.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/offline_stores/redshift.py 90.29% <ø> (ø)
sdk/python/feast/infra/online_stores/datastore.py 90.51% <0.00%> (-2.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 998e169...fb316e4. Read the comment docs.

Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 332577b into feast-dev:master Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants